Issue 5161 - Use maps and sets where appropriate

lib/popupBlocker.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 77 matching lines @@
     forgetPopup(details.tabId);
 }
 
 chrome.webNavigation.onCreatedNavigationTarget.addListener(details =>
 {
   if (loadingPopups.size == 0)
   {
     chrome.webRequest.onBeforeRequest.addListener(
       onPopupURLChanged,
       {
-        urls: ["<all_urls>"],
+        urls: ["http://*/*", "https://*/*"],
         types: ["main_frame"]
       }
     );
     chrome.webNavigation.onCommitted.addListener(onPopupURLChanged);
     chrome.webNavigation.onCompleted.addListener(onCompleted);
     chrome.tabs.onRemoved.addListener(forgetPopup);
   }
 
-  let {tabId} = details;
-
   let popup = {
     url: details.url,
     sourcePage: new ext.Page({id: details.sourceTabId}),
     sourceFrame: null
   };
 
-  loadingPopups.set(tabId, popup);
+  loadingPopups.set(details.tabId, popup);
 
   let frame = ext.getFrame(details.sourceTabId, details.sourceFrameId);
 
   if (checkWhitelisted(popup.sourcePage, frame))
   {
-    forgetPopup(tabId);
+    forgetPopup(details.tabId);
   }
   else
   {
     popup.sourceFrame = frame;
-    checkPotentialPopup(tabId, popup);
+    checkPotentialPopup(details.tabId, popup);
   }
 });