Issue 5034 - Part 3: Create plain JsValue instead of JsValuePtr

test/JsEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <stdexcept>
 #include "BaseJsTest.h"
+#include "../src/JsContext.h"
 
 namespace
 {
   class JsEngineTest : public BaseJsTest
   {
   };
 }
 
 TEST_F(JsEngineTest, Evaluate)
 {
@@ skipping 25 matching lines @@
 
   value = jsEngine->NewValue(true);
   ASSERT_TRUE(value.IsBool());
   ASSERT_TRUE(value.AsBool());
 
   value = jsEngine->NewObject();
   ASSERT_TRUE(value.IsObject());
   ASSERT_EQ(0u, value.GetOwnPropertyNames().size());
 }
 
+namespace {
+
+  bool IsSame(AdblockPlus::JsEngine& jsEngine,
+              const AdblockPlus::JsValue& v1, const AdblockPlus::JsValue& v2)
+  {
+    AdblockPlus::JsValueList params;
+    params.push_back(v1);
+    params.push_back(v2);
+    return jsEngine.Evaluate("f = function(a, b) { return a == b };")->Call(params).AsBool();
+  }
+
+}
+
 TEST_F(JsEngineTest, ValueCopy)
 {
   {
     auto value = jsEngine->NewValue("foo");
     ASSERT_TRUE(value.IsString());
     ASSERT_EQ("foo", value.AsString());
 
     AdblockPlus::JsValue value2(value);
     ASSERT_TRUE(value2.IsString());
     ASSERT_EQ("foo", value2.AsString());
+
+    ASSERT_TRUE(IsSame(*jsEngine, value, value2));
   }
   {
     auto value = jsEngine->NewValue(12345678901234);
     ASSERT_TRUE(value.IsNumber());
     ASSERT_EQ(12345678901234, value.AsInt());
 
     AdblockPlus::JsValue value2(value);
     ASSERT_TRUE(value2.IsNumber());
     ASSERT_EQ(12345678901234, value2.AsInt());
+
+    ASSERT_TRUE(IsSame(*jsEngine, value, value2));
   }
   {
     auto value = jsEngine->NewValue(true);
     ASSERT_TRUE(value.IsBool());
     ASSERT_TRUE(value.AsBool());
 
     AdblockPlus::JsValue value2(value);
     ASSERT_TRUE(value2.IsBool());
     ASSERT_TRUE(value2.AsBool());
+
+    ASSERT_TRUE(IsSame(*jsEngine, value, value2));
   }
   {
     auto value = jsEngine->NewObject();
     ASSERT_TRUE(value.IsObject());
     ASSERT_EQ(0u, value.GetOwnPropertyNames().size());
 
     AdblockPlus::JsValue value2(value);
     ASSERT_TRUE(value2.IsObject());
     ASSERT_EQ(0u, value2.GetOwnPropertyNames().size());
+
+    ASSERT_TRUE(IsSame(*jsEngine, value, value2));
   }

[sergei, 2017/04/19 18:56:52]

Actually, it would be good to test in addition that after calling of a copy-ctr
they both refer to the same JS object.

[hub, 2017/04/19 21:56:49]

Not sure how to do that. This is neither v8::Value::StrictEquals() nor
v8::Value::Equals(). Not even sure it is v8::Value::SameValue() but this API
isn't in the version we are using.

[sergei, 2017/04/20 07:42:52]

I thought about something like

auto obj = jsEngine->NewObject();
auto sameObj = obj;
EXPECT_TRUE(jsEngine->Evaluate("function(a, b){return a == b;}").Call(obj,
sameObj));

My concern was that while copying of JsValue there is no creation of a new
object. In terms of JS, it does not call something like `sameObj =
Object.assign({}, obj);` nor `sameObj = new String(obj)` when obj is a string,
etc.

[hub, 2017/04/20 12:41:01]

ok. this works. and I tested the failure too :-)

 }
 
 TEST_F(JsEngineTest, EventCallbacks)
 {
   bool callbackCalled = false;
   AdblockPlus::JsValueList callbackParams;
   auto Callback = [&callbackCalled, & callbackParams](
     const AdblockPlus::JsValueList& params)
   {
     callbackCalled = true;
@@ skipping 52 matching lines @@
 
 TEST(NewJsEngineTest, GlobalPropertyTest)
 {
   AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New());
   jsEngine->SetGlobalProperty("foo", jsEngine->NewValue("bar"));
   AdblockPlus::JsValuePtr foo = jsEngine->Evaluate("foo");
   ASSERT_TRUE(foo->IsString());
   ASSERT_EQ(foo->AsString(), "bar");
 }