Unified Diff: src/Notification.cpp
Issue 29417605:
Issue 5034 - Part 3: Create plain JsValue instead of JsValuePtr (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Added value test for copy ctor
Created April 20, 2017, 12:40 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« src/JsValue.cpp ('k')
|
src/WebRequestJsObject.cpp » ('j')
|
test/JsEngine.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: src/Notification.cpp |
| =================================================================== |
| --- a/src/Notification.cpp |
| +++ b/src/Notification.cpp |
| @@ -90,17 +90,17 @@ |
| JsValue jsLinks = GetProperty("links"); |
| if (!jsLinks.IsArray()) |
| { |
| return retValue; |
| } |
| JsValueList urlLinksList = jsLinks.AsList(); |
| for (const auto& link : urlLinksList) |
| { |
| - retValue.push_back(link->AsString()); |
| + retValue.push_back(link.AsString()); |
| } |
| return retValue; |
| } |
| void Notification::MarkAsShown() |
| { |
| jsEngine->Evaluate("API.markNotificationAsShown")->Call(GetProperty("id")); |
| } |
« no previous file with comments
|
« src/JsValue.cpp ('k')
|
src/WebRequestJsObject.cpp » ('j')
|
test/JsEngine.cpp » ('J')
