Issue 5165 - Remove SubscriptionPtr

include/AdblockPlus/FilterEngine.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 77 matching lines @@
    * use `GetProperty()` to retrieve them by name.
    */
   class Subscription : public JsValue,
                        public std::enable_shared_from_this<Subscription>
   {
     friend class FilterEngine;
   public:
     /**
      * Copy constructor
      */
-    Subscription(const Subscription&);
+    Subscription(const Subscription& src);
 
     /**
      * Move constructor
      */
-    Subscription(Subscription&&);
+    Subscription(Subscription&& src);
 
     /**
      * Assignment operator
      */
-    Subscription& operator=(const Subscription&);

[sergei, 2017/04/24 18:19:36]

The same comments as in https://codereview.adblockplus.org/29419629/#msg8

[hub, 2017/04/24 19:16:51]

Done.

+    Subscription& operator=(const Subscription& src);
+
+    /**
+     * Move assignment operator
+     */
+    Subscription& operator=(Subscription&& src);
 
     /**
      * Checks if this subscription has been added to the list of subscriptions.
      * @return `true` if this subscription has been added.
      */
     bool IsListed() const;
 
     /**
      * Adds this subscription to the list of subscriptions.
      */
@@ skipping 435 matching lines @@
       const JsValueList& param) const;
     FilterPtr GetWhitelistingFilter(const std::string& url,
       ContentTypeMask contentTypeMask, const std::string& documentUrl) const;
     FilterPtr GetWhitelistingFilter(const std::string& url,
       ContentTypeMask contentTypeMask,
       const std::vector<std::string>& documentUrls) const;
   };
 }
 
 #endif