Issue 5164 - Remove NotificationPtr

include/AdblockPlus/FilterEngine.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 92 matching lines @@
     Subscription(Subscription&& src);
 
     /**
      * Assignment operator
      */
     Subscription& operator=(const Subscription& src);
 
     /**
      * Move assignment operator
      */
     Subscription& operator=(Subscription&& src);

[sergei, 2017/04/24 19:28:15]

This change seems unrelated to this codereview, the codereview is about
Notification, for Subscription there is another codereview.

[hub, 2017/04/24 20:17:04]

I thought for a second I had mixed up code reviews and patches. This only appear
in the interdiff because this patch is based on top of the other (the one for
the subscription). Rebasing has happened.

[sergei, 2017/04/25 07:37:15]

Acknowledged.

 
     /**
      * Checks if this subscription has been added to the list of subscriptions.
      * @return `true` if this subscription has been added.
      */
     bool IsListed() const;
 
     /**
      * Adds this subscription to the list of subscriptions.
      */
@@ skipping 103 matching lines @@
 
     /**
      * Container of name-value pairs representing a set of preferences.
      */
     typedef std::map<std::string, AdblockPlus::JsValue> Prefs;
 
     /**
      * Callback type invoked when a new notification should be shown.
      * The parameter is the Notification object to be shown.
      */
-    typedef std::function<void(const NotificationPtr&)> ShowNotificationCallback;
+    typedef std::function<void(Notification&)> ShowNotificationCallback;
 
     /**
      * Callback function returning false when current connection is not
      * allowedConnectionType, e.g. because it is a metered connection.
      */
     typedef std::function<bool(const std::string* allowedConnectionType)> IsConnectionAllowedCallback;
 
     /**
      * FilterEngine creation parameters.
      */
@@ skipping 311 matching lines @@
       const JsValueList& param) const;
     FilterPtr GetWhitelistingFilter(const std::string& url,
       ContentTypeMask contentTypeMask, const std::string& documentUrl) const;
     FilterPtr GetWhitelistingFilter(const std::string& url,
       ContentTypeMask contentTypeMask,
       const std::vector<std::string>& documentUrls) const;
   };
 }
 
 #endif