Issue 5164 - Remove NotificationPtr

src/Notification.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 39 matching lines @@
     NotificationTypes::const_iterator notificationTypeIterator = std::find_if(
       notificationTypes.begin(), notificationTypes.end(), findBySecond);
     if (notificationTypeIterator == notificationTypes.end())
     {
       return NotificationType::NOTIFICATION_TYPE_INFORMATION;
     }
     return notificationTypeIterator->first;
   }
 }
 
+Notification::Notification(const Notification& src)
+  : JsValue(src)
+{
+}
+
+Notification::Notification(Notification&& src)
+  : JsValue(std::move(src))
+{
+}
+
 Notification::Notification(JsValue&& jsValue)
   : JsValue(std::move(jsValue))
 {
 }
 
+Notification& Notification::operator=(const Notification& src)
+{
+  *this = src;
+  return *this;
+}
+
+Notification& Notification::operator=(Notification&& src)
+{
+  *this = std::move(src);

[sergei, 2017/04/24 19:28:15]

It will cause an infinite recursion. It should be
static_cast<JsValue&>(*this) = std::move(src);

[hub, 2017/04/24 20:17:04]

oops. same with the assignment (copy).

+  return *this;
+}
+
 NotificationType Notification::GetType() const
 {
   return StringToNotificationType(GetProperty("type").AsString());
 }
 
 NotificationTexts Notification::GetTexts() const
 {
   JsValue jsTexts = jsEngine->Evaluate("API.getNotificationTexts").Call(*this);
   NotificationTexts notificationTexts;
   JsValue jsTitle = jsTexts.GetProperty("title");
@@ skipping 22 matching lines @@
   {
     retValue.push_back(link.AsString());
   }
   return retValue;
 }
 
 void Notification::MarkAsShown()
 {
   jsEngine->Evaluate("API.markNotificationAsShown").Call(GetProperty("id"));
 }