Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/Notification.h

Issue 29419629: Issue 5164 - Remove NotificationPtr (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Added move assignment operator. Created April 24, 2017, 7:08 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/AdblockPlus/Notification.h
===================================================================
--- a/include/AdblockPlus/Notification.h
+++ b/include/AdblockPlus/Notification.h
@@ -55,16 +55,36 @@
protected:
/**
* Constructor.
* @param jsValue `JsValue&&` notification JavaScript object.
*/
explicit Notification(JsValue&& jsValue);
public:
/**
+ * Copy constructor
+ */
+ Notification(const Notification& src);
+
+ /**
+ * Move constructor
+ */
+ Notification(Notification&& src);
+
+ /**
+ * Assignment operator
+ */
+ Notification& operator=(const Notification& src);
+
+ /**
+ * Move assignment operator
+ */
+ Notification& operator=(Notification&& src);
+
+ /**
* Retrieves the type of this notification.
* @return Type of this notification.
*/
NotificationType GetType() const;
/**
* Retrieves the title and message of this notification.
* @return Translated texts.
@@ -79,12 +99,11 @@
/**
* Marks this notification as shown. It is only relevant for question
* notifications. Other notifications are marked automatically.
*/
void MarkAsShown();
private:
};
- typedef std::shared_ptr<Notification> NotificationPtr;
}
#endif

Powered by Google App Engine
This is Rietveld