Issue 5164 - Remove NotificationPtr

src/Notification.cpp

Index: src/Notification.cpp
===================================================================
--- a/src/Notification.cpp
+++ b/src/Notification.cpp
@@ -52,21 +52,43 @@
     if (notificationTypeIterator == notificationTypes.end())
     {
       return NotificationType::NOTIFICATION_TYPE_INFORMATION;
     }
     return notificationTypeIterator->first;
   }
 }
 
+Notification::Notification(const Notification& src)
+  : JsValue(src)
+{
+}
+
+Notification::Notification(Notification&& src)
+  : JsValue(std::move(src))
+{
+}
+
 Notification::Notification(JsValue&& jsValue)
   : JsValue(std::move(jsValue))
 {
 }
 
+Notification& Notification::operator=(const Notification& src)
+{
+  *this = src;
+  return *this;
+}
+
+Notification& Notification::operator=(Notification&& src)
+{
+  *this = std::move(src);

[sergei, 2017/04/24 19:28:15]

It will cause an infinite recursion. It should be
static_cast<JsValue&>(*this) = std::move(src);

[hub, 2017/04/24 20:17:04]

oops. same with the assignment (copy).

+  return *this;
+}
+
 NotificationType Notification::GetType() const
 {
   return StringToNotificationType(GetProperty("type").AsString());
 }
 
 NotificationTexts Notification::GetTexts() const
 {
   JsValue jsTexts = jsEngine->Evaluate("API.getNotificationTexts").Call(*this);