Issue 5182 - fix IsConnectionAllowed

lib/compat.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 366 matching lines @@
   },
 
   send: function(data)
   {
     if (this.readyState != 1)
       throw new Error("XMLHttpRequest.send() is being called before XMLHttpRequest.open()");
     if (typeof data != "undefined" && data)
       throw new Error("Sending data to server is not supported");
 
     this.readyState = 3;
-    window._webRequest.GET(this._url, this._requestHeaders, function(result)
+
+    var onGetDone = function(result)
     {
       this.channel.status = result.status;
       this.status = result.responseStatus;
       this.responseText = result.responseText;
       this._responseHeaders = result.responseHeaders;
       this.readyState = 4;
 
       // Notify event listeners
       const NS_OK = 0;
       var eventName = (this.channel.status == NS_OK ? "load" : "error");
       var event = {type: eventName};
 
       if (this["on" + eventName])
         this.onload.call(this, event);
 
       var list = this["_" + eventName + "Handlers"];
       for (var i = 0; i < list.length; i++)
         list[i].call(this, event);
+    }.bind(this);
+    // HACK (#5066): the code checking whether the connection is allowed is temporary,
+    // the actual check should be in the core when we make a decision whether
+    // to update a subscription with current connection or not, thus whether to
+    // even construct XMLHttpRequest object or not.
+    _isSubscriptionDownloadAllowed(function(isAllowed)
+    {
+      if (!isAllowed)
+      {
+        onGetDone({
+          status: 0x804b000d, //NS_ERROR_CONNECTION_REFUSED;
+          responseStatus: 0
+        });
+        return;
+      }
+      window._webRequest.GET(this._url, this._requestHeaders, onGetDone);
     }.bind(this));
   },
 
   overrideMimeType: function(mime)
   {
   },
 
   setRequestHeader: function(name, value)
   {
     if (this.readyState > 1)
@@ skipping 21 matching lines @@
     loadFlags: 0,
     INHIBIT_CACHING: 0,
     VALIDATE_ALWAYS: 0,
     QueryInterface: function()
     {
       return this;
     }
   }
 };
 
+function _isSubscriptionDownloadAllowed(callback) {
+  // It's a bit hacky, JsEngine interface which is used by FilterEngine does
+  // not allow to inject an arbitrary callback, so we use triggerEvent
+  // mechanism.
+  // Yet one hack (#5039).
+  var allowed_connection_type = require("prefs").Prefs.allowed_connection_type;
+  if (allowed_connection_type == "")
+    allowed_connection_type = null;
+  _triggerEvent("_isSubscriptionDownloadAllowed", allowed_connection_type, callback);
+}
 
 // Polyfill Array.prototype.find
 // from https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/find
 // https://tc39.github.io/ecma262/#sec-array.prototype.find
 if (!Array.prototype.find) {
   Object.defineProperty(Array.prototype, 'find', {
     value: function (predicate) {
       // 1. Let O be ? ToObject(this value).
       if (this == null) {
         throw new TypeError('"this" is null or not defined');
@@ skipping 24 matching lines @@
         var kValue = o[k];
         if (predicate.call(thisArg, kValue, k, o)) {
           return kValue;
         }
         // e. Increase k by 1.
         k++;
       }
     }
   });
 }