Issue 5137 - [emscripten] Added basic filter storage implementation

compiled/subscription/Subscription.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 39 matching lines @@
 
 #define SUBSCRIPTION_PROPERTY(type, name, topic, getter, setter) \
     static_assert(std::is_arithmetic<type>::value, "SUBSCRIPTION_PROPERTY macro can only be used with arithmetic types");\
     SUBSCRIPTION_PROPERTY_INTERNAL(type, type, name, topic, getter, setter)
 
 #define SUBSCRIPTION_STRING_PROPERTY(name, topic, getter, setter) \
     SUBSCRIPTION_PROPERTY_INTERNAL(OwnedString, const String&, name, topic, getter, setter)
 
 class Subscription : public ref_counted
 {
+public:
+  typedef std::vector<FilterPtr> Filters;
+
 protected:
   OwnedString mID;
-  std::vector<FilterPtr> mFilters;
+  Filters mFilters;
 
 public:
   enum Type
   {
     UNKNOWN = 0,
     DOWNLOADABLE = 1,
     USERDEFINED = 2
   };
 
   explicit Subscription(Type type, const String& id);
   ~Subscription();
 
   Type mType;
 
   BINDINGS_EXPORTED const String& GetID() const
   {
     return mID;
   }
 
   SUBSCRIPTION_STRING_PROPERTY(mTitle, SUBSCRIPTION_TITLE, GetTitle, SetTitle);
   SUBSCRIPTION_PROPERTY(bool, mDisabled, SUBSCRIPTION_DISABLED,
         GetDisabled, SetDisabled);
   SUBSCRIPTION_PROPERTY(bool, mListed, NONE, GetListed, SetListed);

[sergei, 2017/08/24 13:32:06]

To tell the truth I find this flag a bit questionable, but I think we can have
it.

 
-  BINDINGS_EXPORTED unsigned GetFilterCount() const
+  BINDINGS_EXPORTED Filters::size_type GetFilterCount() const
   {
     return mFilters.size();
   }
 
-  BINDINGS_EXPORTED Filter* FilterAt(unsigned index);
+  BINDINGS_EXPORTED Filter* FilterAt(Filters::size_type index);
   BINDINGS_EXPORTED int IndexOfFilter(Filter* filter);
   BINDINGS_EXPORTED OwnedString Serialize() const;
   BINDINGS_EXPORTED OwnedString SerializeFilters() const;
 
   static BINDINGS_EXPORTED Subscription* FromID(const String& id);
 
   template<typename T>
   T* As();
 };
 
 typedef intrusive_ptr<Subscription> SubscriptionPtr;