Issue 5216 - [emscripten] Use a more reliable way of retrieving mangled function name

compile

 #!/usr/bin/env python
 
 # This file is part of Adblock Plus <https://adblockplus.org/>,
 # Copyright (C) 2006-2017 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 23 matching lines @@
     'TOTAL_STACK': 1*1024*1024,
     'ALLOW_MEMORY_GROWTH': 1,
     'NO_EXIT_RUNTIME': 1,
     'NO_DYNAMIC_EXECUTION': 1,
     'NO_FILESYSTEM': 1,
     'INVOKE_RUN': 0,
     'TEXTDECODER': 0,
     'EXPORTED_RUNTIME_METHODS': ['cwrap', 'ccall', 'stringToAscii'],
 }
 DEFINES = []
-ADDITIONAL_PARAMS = ['-O3', '-m32', '-std=gnu++14', '--memory-init-file', '0',
+ADDITIONAL_PARAMS = ['-O3', '-m32', '-std=c++1z', '--memory-init-file', '0',
                      '--emit-symbol-map', '-Wall', '-Werror', '-fno-exceptions',
                      '-fno-rtti', '--js-library', JS_LIBRARY]
 
 
 def get_source_files(phase):
     for (path, dirs, files) in os.walk(SOURCE_DIR):
         for f in files:
             if os.path.splitext(f)[1] != '.cpp':
                 continue
             if (
@@ skipping 13 matching lines @@
         'EMSCRIPTEN': scope['EMSCRIPTEN_ROOT'],
         'PYTHON': scope.get('PYTHON', sys.executable),
         'NODE_JS': scope.get('NODE_JS', 'node'),
     })
     return env
 
 
 def generate_bindings(env):
     params = [
         env['PYTHON'], os.path.join(env['EMSCRIPTEN'], 'emcc'),
         '-o', BINDINGS_GENERATOR, '-std=c++1z', '--js-library', JS_LIBRARY,

[sergei, 2017/05/08 10:58:19]

does c++1z influence somehow on the generated code/size/something else?

[Wladimir Palant, 2017/05/08 11:41:34]

No, the build is identical. The only thing changing is the non-const
string::data() being available.

I realized that I changed this parameter only for the bindings, not for the
final build - fixed now.

         '--js-library', os.path.join(SOURCE_DIR, 'bindings', 'library.js'),
     ] + list(get_source_files('bindings'))
     subprocess.check_call(params, env=env)
 
     with open(BINDINGS_OUTPUT, 'w') as file:
         subprocess.check_call([env['NODE_JS'], BINDINGS_GENERATOR],
                               stdout=file)
 
 
 def run_compiler(env, debug=False, tracing=False):
@@ skipping 34 matching lines @@
     parser.add_argument(
         '-t', '--tracing',
         action='store_true',
         help='Enable memory tracing'
     )
     args = parser.parse_args()
 
     env = getenv(args.emscripten_config)
     generate_bindings(env)
     run_compiler(env, debug=args.debug, tracing=args.tracing)