Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: composer.postload.js

Issue 29436567: Issue 3200 - Delay initialization for prerendered documents (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Left Patch Set: Delay composer.ready until document is visible Created May 12, 2017, 1:30 p.m.
Right Patch Set: Move common logic into separate function Created Aug. 24, 2017, 2:06 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | include.preload.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
(...skipping 562 matching lines...) Expand 10 before | Expand all | Expand 10 after
576 type: "composer.content.finished" 576 type: "composer.content.finished"
577 } 577 }
578 }); 578 });
579 } 579 }
580 break; 580 break;
581 } 581 }
582 }); 582 });
583 583
584 if (window == window.top) 584 if (window == window.top)
585 { 585 {
586 if (document.visibilityState == "prerender") 586 whenDocumentVisible(() =>
587 {
588 document.addEventListener("visibilitychange", function onVisibilitychange( )
kzar 2017/05/19 12:33:05 Nit: Long line. Also it's kind of unusual how you
Manish Jethani 2017/05/19 23:58:48 Sure, I wasn't sure what the preferred style was.
589 {
590 document.removeEventListener("visibilitychange", onVisibilitychange);
591
592 ext.backgroundPage.sendMessage({type: "composer.ready"});
593 });
594 }
595 else
596 { 587 {
597 ext.backgroundPage.sendMessage({type: "composer.ready"}); 588 ext.backgroundPage.sendMessage({type: "composer.ready"});
598 } 589 });
599 } 590 }
600 } 591 }
LEFTRIGHT
« no previous file | include.preload.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld