Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: test/BaseJsTest.cpp

Issue 29442722: Issue 3593 - stop sharing v8::Isolate among tests (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: address comments Created May 26, 2017, 10:54 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/JsEngine.cpp ('k') | test/JsEngine.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 24 matching lines...) Expand all
35 JsEngineCreationParameters::JsEngineCreationParameters() 35 JsEngineCreationParameters::JsEngineCreationParameters()
36 : logSystem(std::make_shared<ThrowingLogSystem>()) 36 : logSystem(std::make_shared<ThrowingLogSystem>())
37 , timer(new ThrowingTimer()) 37 , timer(new ThrowingTimer())
38 , webRequest(new ThrowingWebRequest()) 38 , webRequest(new ThrowingWebRequest())
39 , fileSystem(std::make_shared<ThrowingFileSystem>()) 39 , fileSystem(std::make_shared<ThrowingFileSystem>())
40 { 40 {
41 } 41 }
42 42
43 AdblockPlus::JsEnginePtr CreateJsEngine(JsEngineCreationParameters&& jsEngineCre ationParameters) 43 AdblockPlus::JsEnginePtr CreateJsEngine(JsEngineCreationParameters&& jsEngineCre ationParameters)
44 { 44 {
45 static AdblockPlus::ScopedV8IsolatePtr isolate = std::make_shared<AdblockPlus: :ScopedV8Isolate>();
46 auto jsEngine = AdblockPlus::JsEngine::New(jsEngineCreationParameters.appInfo, 45 auto jsEngine = AdblockPlus::JsEngine::New(jsEngineCreationParameters.appInfo,
47 std::move(jsEngineCreationParameters.timer), 46 std::move(jsEngineCreationParameters.timer),
48 std::move(jsEngineCreationParameters.webRequest), 47 std::move(jsEngineCreationParameters.webRequest));
49 isolate);
50 jsEngine->SetLogSystem(std::move(jsEngineCreationParameters.logSystem)); 48 jsEngine->SetLogSystem(std::move(jsEngineCreationParameters.logSystem));
51 jsEngine->SetFileSystem(std::move(jsEngineCreationParameters.fileSystem)); 49 jsEngine->SetFileSystem(std::move(jsEngineCreationParameters.fileSystem));
52 return jsEngine; 50 return jsEngine;
53 } 51 }
OLDNEW
« no previous file with comments | « src/JsEngine.cpp ('k') | test/JsEngine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld