Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: templates/edgeInfo.js.tmpl

Issue 29454678: Issue 5085 - Add edgeInfo.js template for edge specific builds (Closed)
Left Patch Set: fix regexp in edge tmpl, remove platformVersion from chrome tmpl Created June 7, 2017, 4:17 p.m.
Right Patch Set: remove unecessary variable Created June 8, 2017, 3:46 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « templates/chromeInfo.js.tmpl ('k') | templates/modules.js.tmpl » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* This Source Code Form is subject to the terms of the Mozilla Public 1 /* This Source Code Form is subject to the terms of the Mozilla Public
2 * License, v. 2.0. If a copy of the MPL was not distributed with this 2 * License, v. 2.0. If a copy of the MPL was not distributed with this
3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ 3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
4 4
5 "use strict"; 5 "use strict";
6
7 let platformVersion = "0";
8
9 let match = /\bEdge\/(\S+(?:\.\d+)?)\b/.exec(navigator.userAgent);
Sebastian Noack 2017/06/08 08:52:30 \S matches any non-whiespace characters, but we re
Jon Sonesen 2017/06/08 15:47:28 Done.
10 if (match)
11 platformVersion = match[1];
Sebastian Noack 2017/06/08 08:52:30 If you assign directly to exports.platformVersion
Jon Sonesen 2017/06/08 15:47:28 Done.
12 6
13 exports.addonName = {{ basename|json }}; 7 exports.addonName = {{ basename|json }};
14 exports.addonVersion = {{ version|json }}; 8 exports.addonVersion = {{ version|json }};
15 9
16 exports.application = "edge"; 10 exports.application = "edge";
17 exports.applicationVersion = "0"; 11 exports.applicationVersion = "0";
18 12
19 exports.platform = "edgehtml" 13 exports.platform = "edgehtml"
20 exports.platformVersion = platformVersion; 14 exports.platformVersion = "0";
15
16 let match = /\bEdge\/(\d+(?:\.\d+)?)\b/.exec(navigator.userAgent);
17 if (match)
18 exports.platformVersion = match[1];
LEFTRIGHT

Powered by Google App Engine
This is Rietveld