Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: templates/edgeInfo.js.tmpl

Issue 29454678: Issue 5085 - Add edgeInfo.js template for edge specific builds (Closed)
Patch Set: remove chrome specific code from edge template, and edge specific from chrome Created June 7, 2017, 11:06 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: templates/edgeInfo.js.tmpl
===================================================================
new file mode 100644
--- /dev/null
+++ b/templates/edgeInfo.js.tmpl
@@ -0,0 +1,36 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+"use strict";
+
+let platform = "edgehtml";
+let platformVersion = null;
+let application = "edge";
+let applicationVersion = "0";
+
+let regexp = /(\S+)\/(\S+)(?:\s*\(.*?\))?/g;
+let match;
+
+while (match = regexp.exec(navigator.userAgent))
+{
+ let app = match[1];
+ let ver = match[2];
+ platformVersion = ver;
+}
+
+// not a Chromium-based UA, probably modifed by the user
Jon Sonesen 2017/06/07 11:08:43 Not sure if I should change the comment, seems it
+if (!platformVersion)
+{
+ application = "unknown";
+ applicationVersion = platformVersion = "0";
+}
+
+exports.addonName = {{ basename|json }};
+exports.addonVersion = {{ version|json }};
+
+exports.application = application;
Sebastian Noack 2017/06/07 11:14:13 Since this code is only bundled with the build for
Jon Sonesen 2017/06/07 11:41:38 Acknowledged. What about the logic if platform ver
Sebastian Noack 2017/06/07 11:51:46 If the regular expression fails we should still se
Jon Sonesen 2017/06/07 13:09:28 Acknowledged.
+exports.applicationVersion = applicationVersion;
+
+exports.platform = platform;
+exports.platformVersion = platformVersion;

Powered by Google App Engine
This is Rietveld