Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/csp.js

Issue 29458601: Issue 5315 - Add support for Microsoft Edge (Closed)
Patch Set: Future proof in case Edge supports OBJECT request interception Created June 28, 2017, 4:30 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « inject.preload.js ('k') | lib/requestBlocker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/csp.js
===================================================================
--- a/lib/csp.js
+++ b/lib/csp.js
@@ -17,10 +17,12 @@
"use strict";
-// Before Chrome 58, the webRequest API did not intercept WebSocket
-// connections (see https://crbug.com/129353). Hence we inject CSP headers,
-// below, as a workaround.
-if (!("WEBSOCKET" in chrome.webRequest.ResourceType))
+// The webRequest API doesn't support WebSocket connection blocking in Microsoft
+// Edge and versions of Chrome before 58. Therefore for those we inject CSP
+// headers below as a workaround. See https://crbug.com/129353 and
+// https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10297376/
+if (!chrome.webRequest.ResourceType ||
+ !("WEBSOCKET" in chrome.webRequest.ResourceType))
{
const {defaultMatcher} = require("matcher");
const {BlockingFilter, RegExpFilter} = require("filterClasses");
« no previous file with comments | « inject.preload.js ('k') | lib/requestBlocker.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld