Issue 5079 - Turn elemHideEmulation into a CommonJS module

lib/content/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 32 matching lines @@
     else if (sep == "")
     {
       if (chr == '"' || chr == "'")
         sep = chr;
       else if (chr == "(")  // don't split between parentheses
         level++;            // e.g. :matches(div,span)
       else if (chr == ")")
         level = Math.max(0, level - 1);
       else if (chr == "," && level == 0)
       {
-        selectors.push(selector.substring(start, i).trim());
+        selectors.push(selector.substring(start, i));
         start = i + 1;
       }
     }
   }
 
-  selectors.push(selector.substring(start).trim());
+  selectors.push(selector.substring(start));
   return selectors;
 }
 
 /** Return position of node from parent.
  * @param {Node} node the node to find the position of.
  * @return {number} One-based index like for :nth-child(), or 0 on error.
  */
 function positionInParent(node)
 {
   let {children} = node.parentNode;
@@ skipping 112 matching lines @@
    * @param {Node} subtree the subtree we work on.
    * @param {StringifiedStyle[]} styles the stringified style objects.
    */
   *getSelectors(prefix, subtree, styles)
   {
     yield [prefix + this._selector, subtree];
   }
 };
 
 const incompletePrefixRegexp = /[\s>+~]$/;
-const relativeSelector = /^[\s>+~]/;
 
 function HasSelector(selectors)
 {
   this._innerSelectors = selectors;
 }
 
 HasSelector.prototype = {
   requiresHiding: true,
 
   get dependsOnStyles()
@@ skipping 15 matching lines @@
    */
   *getElements(prefix, subtree, styles)
   {
     let actualPrefix = (!prefix || incompletePrefixRegexp.test(prefix)) ?
         prefix + "*" : prefix;
     let elements = subtree.querySelectorAll(actualPrefix);
     for (let element of elements)
     {
       let iter = evaluate(this._innerSelectors, 0, "", element, styles);
       for (let selector of iter)
-      {
-        if (relativeSelector.test(selector))
-          selector = ":scope" + selector;
         if (element.querySelector(selector))
           yield element;
-      }
     }
   }
 };
 
 function ContainsSelector(textContent)
 {
   this._text = textContent;
 }
 
 ContainsSelector.prototype = {
@@ skipping 30 matching lines @@
 
   this._regexp = new RegExp(regexpString, "i");
 }
 
 PropsSelector.prototype = {
   preferHideWithSelector: true,
   dependsOnStyles: true,
 
   *findPropsSelectors(styles, prefix, regexp)
   {
-    let actualPrefix = (prefix && !incompletePrefixRegexp.test(prefix)) ?
-        prefix + " " : prefix;
     for (let style of styles)
       if (regexp.test(style.style))
         for (let subSelector of style.subSelectors)
         {
-          if (subSelector == "*")
-            subSelector = "";
-          else
-          {
-            let idx = subSelector.lastIndexOf("::");
-            if (idx != -1)
-              subSelector = subSelector.substr(0, idx);
-          }
-          yield actualPrefix + subSelector;
+          let idx = subSelector.lastIndexOf("::");
+          if (idx != -1)
+            subSelector = subSelector.substr(0, idx);
+          yield prefix + subSelector;
         }
   },
 
   *getSelectors(prefix, subtree, styles)
   {
     for (let selector of this.findPropsSelectors(styles, prefix, this._regexp))
       yield [selector, subtree];
   }
 };
 
@@ skipping 210 matching lines @@
       {
         let {document} = this.window;
         this.addSelectors();
         document.addEventListener("load", this.onLoad.bind(this), true);
       }
     });
   }
 };
 
 exports.ElemHideEmulation = ElemHideEmulation;
 exports.splitSelector = splitSelector;

[Wladimir Palant, 2017/08/16 09:55:53]

This shouldn't export splitSelector. If we need this functionality elsewhere, it
should go into common.js or something like that.

[kzar, 2017/08/16 09:59:05]

Acknowledged, OK I'll move that over while I'm at it.