Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: libadblockplus-android/jni/Utils.cpp

Issue 29465639: Issue 5309 - Subscriptions update causes ANR (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git
Patch Set: remove changes of another codereview@sergz Created June 16, 2017, 1:24 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 env->ReleaseStringUTFChars(str, cStr); 96 env->ReleaseStringUTFChars(str, cStr);
97 97
98 return ret; 98 return ret;
99 } 99 }
100 100
101 jstring JniStdStringToJava(JNIEnv* env, std::string str) 101 jstring JniStdStringToJava(JNIEnv* env, std::string str)
102 { 102 {
103 return env->NewStringUTF(str.c_str()); 103 return env->NewStringUTF(str.c_str());
104 } 104 }
105 105
106 bool stringBeginsWith(const std::string& string, const std::string& beginning)
107 {
108 return string.compare(0, beginning.length(), beginning);
109 }
110
106 jobject NewJniArrayList(JNIEnv* env) 111 jobject NewJniArrayList(JNIEnv* env)
107 { 112 {
108 return env->NewObject(arrayListClass->Get(), arrayListCtor); 113 return env->NewObject(arrayListClass->Get(), arrayListCtor);
109 } 114 }
110 115
111 jmethodID JniGetAddToListMethod(JNIEnv* env, jobject list) 116 jmethodID JniGetAddToListMethod(JNIEnv* env, jobject list)
112 { 117 {
113 JniLocalReference<jclass> clazz(env, env->GetObjectClass(list)); 118 JniLocalReference<jclass> clazz(env, env->GetObjectClass(list));
114 return env->GetMethodID(*clazz, "add", "(Ljava/lang/Object;)Z"); 119 return env->GetMethodID(*clazz, "add", "(Ljava/lang/Object;)Z");
115 } 120 }
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 { 184 {
180 return NewJniObject<AdblockPlus::Subscription>( 185 return NewJniObject<AdblockPlus::Subscription>(
181 env, std::move(subscription), subscriptionClass->Get(), subscriptionCtor); 186 env, std::move(subscription), subscriptionClass->Get(), subscriptionCtor);
182 } 187 }
183 188
184 jobject NewJniNotification(JNIEnv* env, AdblockPlus::Notification&& notification ) 189 jobject NewJniNotification(JNIEnv* env, AdblockPlus::Notification&& notification )
185 { 190 {
186 return NewJniObject<AdblockPlus::Notification>( 191 return NewJniObject<AdblockPlus::Notification>(
187 env, std::move(notification), notificationClass->Get(), notificationCtor); 192 env, std::move(notification), notificationClass->Get(), notificationCtor);
188 } 193 }
OLDNEW
« no previous file with comments | « libadblockplus-android/jni/Utils.h ('k') | libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld