libadblockplus-android/jni/JniJsEngine.cpp - Issue 29465639: Issue 5309 - Subscriptions update causes ANR

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: libadblockplus-android/jni/JniJsEngine.cpp

Issue 29465639: Issue 5309 - Subscriptions update causes ANR (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git

Left Patch Set: address comments@sergz Created June 16, 2017, 11:11 a.m.

Right Patch Set: rebase Created July 5, 2017, 1:47 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-2017 eyeo GmbH	3 * Copyright (C) 2006-2017 eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 235 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
246	246

247 { (char)"newValue", (char)"(JJ)" TYP("JsValue"), (void*)JniNewLongValue },	247 { (char)"newValue", (char)"(JJ)" TYP("JsValue"), (void*)JniNewLongValue },

248 { (char)"newValue", (char)"(JZ)" TYP("JsValue"), (void*)JniNewBooleanValue } ,	248 { (char)"newValue", (char)"(JZ)" TYP("JsValue"), (void*)JniNewBooleanValue } ,

249 { (char)"newValue", (char)"(JLjava/lang/String;)" TYP("JsValue"), (void*)Jni NewStringValue }	249 { (char)"newValue", (char)"(JLjava/lang/String;)" TYP("JsValue"), (void*)Jni NewStringValue }

250 };	250 };

251	251

252 extern "C" JNIEXPORT void JNICALL Java_org_adblockplus_libadblockplus_JsEngine_r egisterNatives(JNIEnv *env, jclass clazz)	252 extern "C" JNIEXPORT void JNICALL Java_org_adblockplus_libadblockplus_JsEngine_r egisterNatives(JNIEnv *env, jclass clazz)

253 {	253 {

254 env->RegisterNatives(clazz, methods, sizeof(methods) / sizeof(methods[0]));	254 env->RegisterNatives(clazz, methods, sizeof(methods) / sizeof(methods[0]));

255 }	255 }

LEFT	RIGHT