Issue 5325 - Add support for separator characters

test/abp2blocklist.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 44 matching lines @@
     // Element hiding rules should be in the following order: (1) generic
     // rules, (2) exceptions for generic rules, (3) domain-specific rules,
     // (4) exceptions for all rules.
     testRules(test, [
       "##.whatever",
       "test.com###something",
       "@@||special.test.com^$elemhide",
       "@@||test.com^$generichide"
     ], [
       ["^https?://", "css-display-none"],
-      ["^https?://([^/]+\\.)?test\\.com", "ignore-previous-rules"],
+      ["^https?://([^/]+\\.)?test\\.com([^-_.%a-z0-9].*)?$",
+       "ignore-previous-rules"],
       ["^https?://([^/:]*\\.)?test\\.com[/:]", "css-display-none"],
-      ["^https?://([^/]+\\.)?special\\.test\\.com", "ignore-previous-rules"]
+      ["^https?://([^/]+\\.)?special\\.test\\.com([^-_.%a-z0-9].*)?$",
+       "ignore-previous-rules"]
     ], rules => rules.map(rule => [rule.trigger["url-filter"],
                                    rule.action.type]));
 
     testRules(test, ["#@#whatever"], []);
     testRules(test, ["test.com#@#whatever"], []);
     testRules(test, ["~test.com#@#whatever"], []);
 
     // We currently completely ignore any element hiding filters that have the
     // same selector as an element hiding exception. In these examples #whatever
     // should be hidden for all domains not ending in test.com instead of
     // nowhere!
     testRules(test, ["test.com#@#whatever", "##whatever"], []);
     testRules(test, ["~test.com##whatever"], []);
 
     test.done();
   },
 
   testRequestFilters: function(test)
   {
-    testRules(test, ["/foo", "||test.com", "http://example.com/foo"], [
+    testRules(test, ["/foo", "||test.com^", "http://example.com/foo", "^foo^"], [
       {trigger: {"url-filter": "^https?://.*/foo",
                  "resource-type": ["image", "style-sheet", "script", "font",
                                    "media", "raw", "document"],
                  "unless-top-url": ["^https?://.*/foo"]},
        action: {type: "block"}},
-      {trigger: {"url-filter": "^https?://([^/]+\\.)?test\\.com",
+      {trigger: {"url-filter": "^https?://([^/]+\\.)?test\\.com([^-_.%a-z0-9].*)?$",
                  "url-filter-is-case-sensitive": true,
                  "resource-type": ["image", "style-sheet", "script", "font",
                                    "media", "raw", "document"],
-                 "unless-top-url": ["^https?://([^/]+\\.)?test\\.com"],
+                 "unless-top-url": ["^https?://([^/]+\\.)?test\\.com([^-_.%a-z0-9].*)?$"],
                  "top-url-filter-is-case-sensitive": true},
        action: {type: "block"}},
       {trigger: {"url-filter": "http://example\\.com/foo",
                  "resource-type": ["image", "style-sheet", "script", "font",
                                    "media", "raw", "document"],
                  "unless-top-url": ["http://example\\.com/foo"]},
+       action: {type: "block"}},
+      {trigger: {"url-filter": "^https?://(.*[^-_.%A-Za-z0-9])?foo([^-_.%A-Za-z0-9].*)?$",
+                 "resource-type": ["image", "style-sheet", "script", "font",
+                                   "media", "raw", "document"],
+                 "unless-top-url": ["^https?://(.*[^-_.%A-Za-z0-9])?foo([^-_.%A-Za-z0-9].*)?$"]},
        action: {type: "block"}}
     ]);
 
     testRules(test, ["||example.com"], [
       {trigger: {"url-filter": "^https?://([^/]+\\.)?example\\.com",
                  "url-filter-is-case-sensitive": true,
                  "resource-type": ["image", "style-sheet", "script", "font",
                                    "media", "raw", "document"],
                  "unless-top-url": ["^https?://([^/]+\\.)?example\\.com"],
                  "top-url-filter-is-case-sensitive": true},
@@ skipping 41 matching lines @@
   {
     testRules(test, ["@@||example.com^$document"], [
       {trigger: {"url-filter": ".*",
                  "if-domain": ["*example.com"]},
        action: {type: "ignore-previous-rules"}}
     ]);
     testRules(test, ["@@||example.com^$document,image"], [
       {trigger: {"url-filter": ".*",
                  "if-domain": ["*example.com"]},
        action: {type: "ignore-previous-rules"}},
-      {trigger: {"url-filter": "^https?://([^/]+\\.)?example\\.com",
+      {trigger: {"url-filter": "^https?://([^/]+\\.)?example\\.com([^-_.%a-z0-9].*)?$",
                  "url-filter-is-case-sensitive": true,
                  "resource-type": ["image"]},
        action: {type: "ignore-previous-rules"}}
     ]);
     testRules(test, ["@@||example.com/path^$font,document"], [
-      {trigger: {"url-filter": "^https?://([^/]+\\.)?example\\.com/path",
+      {trigger: {"url-filter": "^https?://([^/]+\\.)?example\\.com/path([^-_.%A-Za-z0-9].*)?$",

[kzar, 2017/07/07 12:46:18]

Nit: Mind fixing these long lines where possible?

[Manish Jethani, 2017/07/08 06:33:57]

Acknowledged.

I'll try to fix this.

[Manish Jethani, 2017/07/09 10:50:52]

Done.

                  "resource-type": ["font"]},
        action: {type: "ignore-previous-rules"}}
     ]);
 
     test.done();
   },
 
   testGenericblockExceptions: function(test)
   {
     testRules(test, ["^ad.jpg|", "@@||example.com^$genericblock"],
@@ skipping 93 matching lines @@
   testUnicode: function(test)
   {
     testRules(test, ["$domain=🐈.cat"], ["*xn--zn8h.cat"],
               rules => rules[0]["trigger"]["if-domain"]);
     testRules(test, ["🐈$domain=🐈.cat"], []);
     testRules(test, ["###🐈"], []);
 
     test.done();
   }
 };