#1634 - Update file resource syntax in module adblockplus

modules/adblockplus/manifests/init.pp

 # == Class: adblockplus
 #
 # The adblockplus class and the associated adblockplus:: namespace are
 # used to integrate Puppet modules with each other, in order to assemble
 # the setups used by the Adblock Plus project.
 #
 # === Parameters:
 #
 # [*authority*]
 #   The authorative domain or zone associated with the current environment.
@@ skipping 42 matching lines @@
     stage => 'runtime',
   }
 
   # Used as internal constant within adblockplus::* resources
   $directory = '/var/adblockplus'
 
   # A common location for directories specific to the adblockplus:: setups,
   # managed via Puppet, but accessible by all users with access to the system
   @file {$directory:
     ensure => 'directory',
-    mode => 0755,
+    mode => '0755',
     owner => 'root',
   }
 
   # A common time-zone shared by all hosts provisioned eases synchronization
   # and debugging, i.e. log-file review and similar tasks, significantly
   file {
     '/etc/timezone':
       content => 'UTC',
       ensure => 'present',
       group => 'root',
-      mode => 0644,
+      mode => '0644',
       notify => Service['cron'],
       owner => 'root';
     '/etc/localtime':
       ensure => 'link',
       target => '/usr/share/zoneinfo/UTC',
       notify => Service['cron'];
   }
 
   # Explicit resource required only to ensure cron(8) is running;
   # there is no real requirement for a rationship with another resource
   service {'cron':
     ensure => 'running',
     enable => true,
   }
 
   $cron_env = hiera('cron::environment', [])
 
   file { '/etc/crontab':
     ensure => 'present',
     content => template('adblockplus/crontab.erb'),
     owner => 'root',
     group => 'root',
-    mode => 0644,
+    mode => '0644',
   }
 
   # Work around https://issues.adblockplus.org/ticket/3479
   if $::environment == 'development' {
 
     file {
       '/etc/ssh/ssh_host_rsa_key':
         source => 'puppet:///modules/adblockplus/development_host_rsa_key',
-        mode => 600,
+        mode => '600',

[mathias, 2017/06/20 17:09:02]

Now that we're at it, can't we make it uniform and always use the same notation,
be it with or without leading zero?

         notify => Service['ssh'];
       '/etc/ssh/ssh_host_rsa_key.pub':
         source => 'puppet:///modules/adblockplus/development_host_rsa_key.pub',
-        mode => 644;
+        mode => '644';
     }
   }
 
   # Fix implicit package dependency Class['apt'] does not properly handle
   Exec['apt_update'] -> Package<|title != 'python-software-properties'|>
 
   # https://issues.adblockplus.org/ticket/3574#comment:19
   ensure_packages($packages)
 
   # https://projects.puppetlabs.com/issues/4145
   ensure_resource('file', '/etc/ssh/ssh_known_hosts', {
     ensure => 'present',
-    mode => 0644,
+    mode => '0644',
   })
 
   # See modules/adblockplus/manifests/host.pp
   create_resources('adblockplus::host', $hosts)
 
   # See modules/adblockplus/manifests/user.pp
   create_resources('adblockplus::user', $users)
 }