Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: adblockplussbrowser/build.gradle

Issue 29479601: Issue 5273 - Automatically update bundled lists (Closed)
Left Patch Set: Created July 4, 2017, 12:50 p.m.
Right Patch Set: Formatting and output when lists were updated Created July 7, 2017, 7:57 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | build.gradle » ('j') | build.gradle » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1
anton 2017/07/06 06:40:24 this change (new line) is not required
jens 2017/07/06 07:54:16 Acknowledged.
2 apply plugin: 'com.android.application' 1 apply plugin: 'com.android.application'
3 2
4 android { 3 android {
5 compileSdkVersion rootProject.ext.compileSdkVersion 4 compileSdkVersion rootProject.ext.compileSdkVersion
6 buildToolsVersion rootProject.ext.buildToolsVersion 5 buildToolsVersion rootProject.ext.buildToolsVersion
7 6
8 compileOptions { 7 compileOptions {
9 sourceCompatibility = rootProject.ext.sourceCompatibilityVersion 8 sourceCompatibility = rootProject.ext.sourceCompatibilityVersion
10 targetCompatibility = rootProject.ext.targetCompatibilityVersion 9 targetCompatibility = rootProject.ext.targetCompatibilityVersion
11 } 10 }
(...skipping 17 matching lines...) Expand all
29 buildTypes { 28 buildTypes {
30 release { 29 release {
31 minifyEnabled true 30 minifyEnabled true
32 proguardFiles getDefaultProguardFile('proguard-android.txt') 31 proguardFiles getDefaultProguardFile('proguard-android.txt')
33 lintOptions { 32 lintOptions {
34 disable 'MissingTranslation' 33 disable 'MissingTranslation'
35 } 34 }
36 } 35 }
37 } 36 }
38 37
39 // update bundles lists when running a release build
40 afterEvaluate { project -> 38 afterEvaluate { project ->
41 project.tasks.prepareReleaseDependencies << { 39 project.tasks.prepareReleaseDependencies << {
42 updateBundledLists() 40 updateBundledLists()
anton 2017/07/06 06:40:24 it would be great to output that the lists are upd
jens 2017/07/06 07:54:16 Good idea, I will add a console output message.
41 println('Bundled lists updated at ' + new Date().format('dd MMM yyyy , HH:mm:ss zzz'))
43 } 42 }
44 } 43 }
45 } 44 }
46 45
47 def updateBundledLists() { 46 def updateBundledLists() {
48 new URL(rootProject.ext.easyListUpdateUrl).withInputStream{ 47 new URL(rootProject.ext.easyListUpdateUrl).withInputStream {
49 i -> new File(rootProject.ext.easyListFilePath).withOutputStream{ it << i }} 48 i -> new File(rootProject.ext.easyListFilePath).withOutputStream { it << i }
50 new URL(rootProject.ext.exceptionRulesUpdateUrl).withInputStream{ i 49 }
51 -> new File(rootProject.ext.exceptionRulesFilePath).withOutputStream{ it << i }} 50 new URL(rootProject.ext.exceptionRulesUpdateUrl).withInputStream {
51 i -> new File(rootProject.ext.exceptionRulesFilePath).withOutputStream { it << i }
52 }
52 } 53 }
53 54
54 dependencies { 55 dependencies {
55 compile "com.android.support:support-v4:$rootProject.ext.androidSupportLibra ryVersion" 56 compile "com.android.support:support-v4:$rootProject.ext.androidSupportLibra ryVersion"
56 } 57 }
LEFTRIGHT
« no previous file | build.gradle » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld