Noissue - Use buffer for FileSystem IO

test/BaseJsTest.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 87 matching lines @@
   void operator()(LogLevel logLevel, const std::string& message,
         const std::string& source)
   {
     throw std::runtime_error("Unexpected error: " + message);
   }
 };
 
 class ThrowingFileSystem : public AdblockPlus::FileSystem
 {
 public:
-  std::shared_ptr<std::istream> Read(const std::string& path) const
+  FileSystem::IOBuffer Read(const std::string& path) const
   {
     throw std::runtime_error("Not implemented");
   }
 
-  void Write(const std::string& path, std::istream& content)
+  void Write(const std::string& path, const FileSystem::IOBuffer& content)
   {
     throw std::runtime_error("Not implemented");
   }
 
   void Move(const std::string& fromPath, const std::string& toPath)
   {
     throw std::runtime_error("Not implemented");
   }
 
   void Remove(const std::string& path)
@@ skipping 18 matching lines @@
 public:
   void GET(const std::string& url, const AdblockPlus::HeaderList& requestHeaders, const GetCallback&) override
   {
     throw std::runtime_error("Unexpected GET: " + url);
   }
 };
 
 class LazyFileSystem : public AdblockPlus::FileSystem
 {
 public:
-  std::shared_ptr<std::istream> Read(const std::string& path) const
+  IOBuffer Read(const std::string& path) const
   {
     std::string dummyData("");
     if (path == "patterns.ini")
       dummyData = "# Adblock Plus preferences\n[Subscription]\nurl=~fl~";
     else if (path == "prefs.json")
       dummyData = "{}";
-    return std::shared_ptr<std::istream>(new std::istringstream(dummyData));
+    return IOBuffer(dummyData.cbegin(), dummyData.cend());
   }
 
-  void Write(const std::string& path, std::istream& content)
+  void Write(const std::string& path, const IOBuffer& content)
   {
   }
 
   void Move(const std::string& fromPath, const std::string& toPath)
   {
   }
 
   void Remove(const std::string& path)
   {
   }
@@ skipping 67 matching lines @@
 protected:
   AdblockPlus::JsEnginePtr jsEngine;
 
   virtual void SetUp()
   {
     jsEngine = CreateJsEngine();
   }
 };
 
 #endif