Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/Utils.cpp

Issue 29481704: Noissue - Use buffer for FileSystem IO (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Nit addressed Created July 7, 2017, 12:50 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/Utils.h ('k') | test/BaseJsTest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/Utils.cpp
===================================================================
--- a/src/Utils.cpp
+++ b/src/Utils.cpp
@@ -10,35 +10,27 @@
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
*/
-#include <sstream>
#include <stdexcept>
#ifdef _WIN32
#include <Windows.h>
#include <Shlwapi.h>
#endif
#include "Utils.h"
using namespace AdblockPlus;
-std::string Utils::Slurp(std::istream& stream)
-{
- std::stringstream content;
- content << stream.rdbuf();
- return content.str();
-}
-
std::string Utils::FromV8String(const v8::Handle<v8::Value>& value)
{
v8::String::Utf8Value stringValue(value);
if (stringValue.length())
return std::string(*stringValue, stringValue.length());
else
return std::string();
}
« no previous file with comments | « src/Utils.h ('k') | test/BaseJsTest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld