#2007 - Introduce nodejs module

modules/nodejs/manifests/init.pp

 # == Class: nodejs
 #
-# Install nodejs package from source
+# Install nodejs package from NodeSource
 #
 # == Parameters:
 #
 # [*package*]
 #   Overwrite the default package options, to fine-tune the target version (i.e.
 #   ensure => 'latest') or remove nodejs (ensure => 'absent' or 'purged')
 #
 # [*key*]
 #   Overwrite the default apt::key used (given Class['apt'] is defined).
 #
@@ skipping 19 matching lines @@
   },
   $package = {},
   $source = {
     location => 'https://deb.nodesource.com/node_4.x',
     release => downcase($lsbdistcodename),
     repos => 'main',
   },
   $packages = {},
 ) {
 
-  # Used as default $ensure parameter for most resources below
-  $ensure = ensure_state($ensure) ? {

[mathias, 2017/07/10 22:33:40]

Please use actual if/else blocks. That way future changes introducing new
conditional parameter values do not need to perform the same decision.

-    false => 'absent',
-    true => 'present',
+  if ensure_state($ensure) {
+    $ensure = 'present'
+  }
+  else {
+    $ensure = 'absent'
   }
 
   ensure_resource('package', $title, merge({
     name => $title,
     ensure => $ensure,
   }, $package))
 
   # The only package provider recognized implicitly
   ensure_resource('apt::key', $title, merge({
     ensure => $ensure,
     name => 'nodesource',
   }, $key))
 
   ensure_resource('apt::source', $title, merge({
     ensure => $ensure,
     include_src => false,
     name => 'nodesource',
   }, $source))
 
   Apt::Source[$title] <- Apt::Key[$title]
   Apt::Source[$title] -> Package[$title]
 
-  create_resources('nodejs::package', $packages)
+  ensure_resources('nodejs::package', $packages, {
+    ensure => 'present',
+  })
 }