Issue 5433 - move most of v8 related configuration from libadblockplus.gyp into v8.gypi

libadblockplus.gyp

 {
   'conditions': [[
     # We don't want to use curl on Windows and Android, skip the check there
     'OS=="win" or OS=="android"',
     {
       'variables': {
         'have_curl': 0
       }
     },
     {
       'variables': {
         'have_curl': '<!(python check_curl.py)'
       }
     }
-  ],
-  [
-    'OS=="win"', {
-      'targets': [{
-        'target_name': 'build-v8',
-        'type': 'none',
-        'actions': [{
-          'action_name': 'build-v8',
-          'inputs': ['build-v8.cmd'],
-          'outputs': [
-            'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_libplatform.lib',
-            'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_base_0.lib',
-            'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_base_1.lib',
-            'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_base_2.lib',
-            'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_base_3.lib',
-            'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_libbase.lib',
-            'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_libsampler.lib',
-            'build/<(target_arch)/v8/build/<(CONFIGURATION_NAME)/v8_snapshot.lib',
-          ],
-          'action': [
-            'cmd',
-            '/C',
-            'build-v8.cmd',
-            '$(MSBuildBinPath)',
-            '<(target_arch)',
-            '<(CONFIGURATION_NAME)',
-            '$(PlatformToolset)'
-          ]
-        }],
-      }]
-    }
   ]],
-  'includes': ['shell/shell.gyp'],
+  'includes': ['v8.gypi', 'shell/shell.gyp'],
   'targets': [{
     'target_name': 'libadblockplus',
     'type': '<(library)',
+    'dependencies': ['<@(libv8_build_targets)'],
     'xcode_settings':{},
     'include_dirs': [
       'include',
-      'third_party/v8/include',
-      'third_party/v8',

[sergei, 2017/07/20 10:23:00]

Here is a change, it turned out that there is no need in `third_party/v8` longer
(after updating of v8).

+      '<(libv8_include_dir)'
     ],
     'sources': [
       'include/AdblockPlus/ITimer.h',
       'include/AdblockPlus/IWebRequest.h',
       'include/AdblockPlus/DefaultWebRequest.h',
       'include/AdblockPlus/IFileSystem.h',
       'include/AdblockPlus/DefaultFileSystem.h',
       'src/AppInfoJsObject.cpp',
       'src/ConsoleJsObject.cpp',
       'src/DefaultLogSystem.cpp',
@@ skipping 10 matching lines @@
       'src/JsValue.cpp',
       'src/Notification.cpp',
       'src/ReferrerMapping.cpp',
       'src/Thread.cpp',
       'src/Utils.cpp',
       'src/WebRequestJsObject.cpp',
       '<(INTERMEDIATE_DIR)/adblockplus.js.cpp'
     ],
     'direct_dependent_settings': {
       'include_dirs': ['include'],
-      'msvs_settings': {
-        'VCLinkerTool': {
-          'AdditionalLibraryDirectories': ['v8/build/<(CONFIGURATION_NAME)'],
+      'conditions': [[
+        'OS=="win"', {

[sergei, 2017/07/20 10:23:00]

this condition is needed because otherwise libv8_lib_dir is undefined while
compiling on *nix.

+          'msvs_settings': {
+            'VCLinkerTool': {
+              'AdditionalLibraryDirectories': ['<(libv8_lib_dir)'],
+            }
+          }
         }
-      },
+      ]],
     },
     'conditions': [
       ['OS=="linux" or OS=="mac"', {
         'link_settings': {
           'libraries': [
-            'v8/out/<(CONFIGURATION_NAME)/libv8_libplatform.a',
-            'v8/out/<(CONFIGURATION_NAME)/libv8_base.a',
-            'v8/out/<(CONFIGURATION_NAME)/libv8_snapshot.a',
-            'v8/out/<(CONFIGURATION_NAME)/libv8_libbase.a',
-            'v8/out/<(CONFIGURATION_NAME)/libv8_libsampler.a',
-          ]
+            '<@(libv8_libs)'
+          ],
         }
       }],
       ['OS=="win"', {
-        'dependencies': ['build-v8'],
         'link_settings': {
           'libraries': [
-            '-lv8_libplatform',
-            '-lv8_base_0',
-            '-lv8_base_1',
-            '-lv8_base_2',
-            '-lv8_base_3',
-            '-lv8_libbase',
-            '-lv8_libsampler',
-            '-lv8_snapshot',
+            '<@(libv8_libs)',
             '-lwinmm'
           ],
         },
       }],
       ['OS=="android"', {
         'user_libraries': [
-          'android_<(target_arch).release/libv8_libplatform.a',
-          'android_<(target_arch).release/libv8_base.a',
-          'android_<(target_arch).release/libv8_snapshot.a',
-          'android_<(target_arch).release/libv8_libbase.a',
-          'android_<(target_arch).release/libv8_libsampler.a',
+          '<@(libv8_libs)'
         ],
         'standalone_static_library': 1, # disable thin archives
       }],
       ['have_curl==1',
         {
           'sources': [
             'src/DefaultWebRequestCurl.cpp',
           ],
           'link_settings': {
             'libraries': ['-lcurl']
@@ skipping 105 matching lines @@
       'test/WebRequest.cpp'
     ],
     'msvs_settings': {
       'VCLinkerTool': {
         'SubSystem': '1',   # Console
         'EntryPointSymbol': 'mainCRTStartup',
       },
     },
   }]
 }