Issue 5431 - Fix test for copyright update script

update-copyright/tests/test_update_copyright.py

 #!/usr/bin/env python3
 
 import os
 import re
 import datetime
 import subprocess
 import shutil
 import urllib.parse
 
 import pytest
 
 from update_copyright import extract_urls, text_replace, hg_commit, main
 
 data_path = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'data')
 
 
 @pytest.fixture(scope='session')
 def sample_file(tmpdir_factory):
     text = '# {}right (C) 2006-2015 eyeo GmbH\n'.format('Copy')
     text += "value = '{}right (C) 2006-2016 Eyeo GmbH'\n".format('Copy')
     text += '# {}right (C) 2006-2014 example GmbH'.format('Copy')
     sample_file = tmpdir_factory.mktemp('sample_dir').join('sample_file.py')
-    with open(str(sample_file), 'w') as sample_file_path:

[Vasily Kuznetsov, 2017/08/04 16:54:46]

Since now `sample_file` is a `py.path` object, you can just do
`sample_file.write(text)`.

[rosie, 2017/08/05 18:41:07]

Done.

-        sample_file_path.write(text)
+    sample_file.write(text)
     return str(sample_file)
 
 
 def create_repo(sample_file, path):
     subprocess.check_call(['hg', 'init', path])
     with open(os.path.join(path, '.hg', 'hgrc'), 'w+') as hgrc:
         set_user = '[ui]\nusername = Test User <test@example.com>'
         hgrc.write(set_user)
     shutil.copy(sample_file, path)
     subprocess.check_call(['hg', 'commit', '-Am', 'Initial commit',
@@ skipping 69 matching lines @@
     subprocess.check_call(['hg', 'add', '--repository', directory])
     hg_commit(directory, repo)
 
     # Make sure both files contain the commmit message from hg log
     log_1 = subprocess.run(['hg', 'log', '--repository', repo],
                            stdout=subprocess.PIPE)
     assert 'Noissue - Updated copyright year' in str(log_1.stdout)
 
 
 def test_all(sample_file, base_dir):
-    # Copy the sample_file to both repos
-    shutil.copy(sample_file, os.path.join(base_dir, 'repo_1'))

[Vasily Kuznetsov, 2017/08/04 16:54:46]

Isn't the sample file already copied to the repositories when they are created
(line 33)?

[rosie, 2017/08/05 18:41:08]

Done.

-    shutil.copy(sample_file, os.path.join(base_dir, 'repo_2'))
-
     main(urllib.parse.urljoin('file:///', os.path.join(
          base_dir, 'hg_page.html')), None)
 
     # assert hg log for repo_1
     log_1 = subprocess.run(['hg', 'log', '--repository',
                             os.path.join(base_dir, 'repo_1')],
                            stdout=subprocess.PIPE)
     assert 'Noissue - Updated copyright year' in str(log_1.stdout)
 
     # assert the .patch file for repo_2
     assert'Noissue - Updated copyright year' in open('repo_2.patch').read()
     subprocess.call(['rm', 'repo_2.patch'])  # cleanup