Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/FileSystemJsObject.cpp

Issue 29499577: Noissue - code style: use override for overridden methods of MockFileSystem (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created July 27, 2017, 8:48 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/FileSystemJsObject.cpp
diff --git a/test/FileSystemJsObject.cpp b/test/FileSystemJsObject.cpp
index d7dd9e17a12739cf2493f4580b11d055acd25fbb..b0a74d1e1c564e966d147898faac8780c7c31297 100644
--- a/test/FileSystemJsObject.cpp
+++ b/test/FileSystemJsObject.cpp
@@ -41,7 +41,7 @@ namespace
{
}
- void Read(const std::string& path, const ReadCallback& callback) const
+ void Read(const std::string& path, const ReadCallback& callback) const override
{
if (!success)
{
@@ -52,7 +52,7 @@ namespace
}
void Write(const std::string& path, const IOBuffer& data,
- const Callback& callback)
+ const Callback& callback) override
{
if (!success)
{
@@ -66,7 +66,7 @@ namespace
}
void Move(const std::string& fromPath, const std::string& toPath,
- const Callback& callback)
+ const Callback& callback) override
{
if (!success)
{
@@ -78,7 +78,7 @@ namespace
callback("");
}
- void Remove(const std::string& path, const Callback& callback)
+ void Remove(const std::string& path, const Callback& callback) override
{
if (!success)
{
@@ -89,8 +89,7 @@ namespace
callback("");
}
- void Stat(const std::string& path,
- const StatCallback& callback) const
+ void Stat(const std::string& path, const StatCallback& callback) const override
{
StatResult result;
std::string error;
@@ -107,7 +106,7 @@ namespace
callback(result, error);
}
- std::string Resolve(const std::string& path) const
+ std::string Resolve(const std::string& path) const override
{
if (!success)
throw std::runtime_error("Unable to stat " + path);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld