Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: includes/index/style.html

Issue 29499714: Issue 4912 - Update media coverage links on eyeo.com (Closed) Base URL: https://hg.adblockplus.org/web.eyeo.com
Left Patch Set: Use macro, move external link icon to HTML Created Aug. 1, 2017, 9:58 a.m.
Right Patch Set: Refactor alternative text and title for media coverage links Created Aug. 2, 2017, 10:33 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 <style> 1 <style>
2
3 #media
4 {
5 text-align: center;
6 }
2 7
3 #media-links 8 #media-links
4 { 9 {
5 text-align: center;
6 list-style: none; 10 list-style: none;
7 padding: 0; 11 padding: 0;
12 margin-bottom: 0;
8 } 13 }
9 14
10 #media-links li 15 #media-links li
11 { 16 {
12 display: inline-block; 17 display: inline-block;
13 position: relative; 18 position: relative;
14 margin: 0px 10px 20px; 19 margin: 0px 10px 20px;
15 } 20 }
16 21
17 .publication-logo 22 .publisher-logo
18 { 23 {
19 max-height: 25px; 24 max-height: 25px;
20 max-width: 100%; 25 max-width: 100%;
21 } 26 }
22 27
23 .external-link-icon 28 .external-link-icon
juliandoucette 2017/08/02 20:31:13 NIT: I think you could center this icon by positio
24 { 29 {
25 position: absolute; 30 position: absolute;
26 top: 50%; 31 top: 50%;
27 left: 50%; 32 left: 50%;
28 height: 20px; 33 height: 20px;
29 width: 20px; 34 width: 20px;
30 margin-left: -10px; 35 margin-left: -10px;
31 margin-top: -12px; 36 margin-top: -12px;
32 opacity: 0; 37 opacity: 0;
33 } 38 }
34 39
35 #media-links a:hover .external-link-icon, 40 #media-links a:hover .external-link-icon,
36 #media-links a:focus .external-link-icon 41 #media-links a:focus .external-link-icon
37 { 42 {
38 opacity: 1; 43 opacity: 1;
39 } 44 }
40 45
41 #media-links a:hover .publication-logo, 46 #media-links a:hover .publisher-logo,
42 #media-links a:focus .publication-logo 47 #media-links a:focus .publisher-logo
43 { 48 {
44 opacity: 0.2; 49 opacity: 0.2;
juliandoucette 2017/08/02 20:31:13 NIT: It may be hard to see the external link icon
45 } 50 }
46 51
47 @media (max-width: 930px) and (min-width: 620px) 52 #media small
53 {
54 display: block;
55 margin-bottom: 1em;
56 }
57
58 @media (min-width: 620px) and (max-width: 930px)
48 { 59 {
49 #media-links 60 #media-links
ire 2017/08/01 10:04:06 This is to force more than just one lone logo to a
juliandoucette 2017/08/02 20:31:13 NIT: Would you mind adding a comment to make this
50 { 61 {
51 max-width: 600px; 62 max-width: 600px;
52 margin-right: auto; 63 margin-right: auto;
53 margin-left: auto; 64 margin-left: auto;
54 } 65 }
55 } 66 }
56 67
68 @media (min-width: 930px)
69 {
70 #media small
71 {
72 display: none;
73 }
74 }
75
57 </style> 76 </style>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld