Issue 5456 - Add support to specify urlFilters in the notification repository

sitescripts/notifications/parser.py

 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2017 eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 74 matching lines @@
             if 'targets' in notification:
                 current['targets'].append(target)
             else:
                 current['targets'] = [target]
         elif key == 'sample' and is_variant:
             current['sample'] = float(value)
         elif key in ['start', 'end']:
             current[key] = datetime.datetime.strptime(value, '%Y-%m-%dT%H:%M')
         elif key == 'interval':
             current[key] = int(value)
+        elif key == 'urls':
+            current['urlFilters'] = ["{}^$document".format(v.upper())

[Vasily Kuznetsov, 2017/08/03 17:08:52]

Our style guide recommends single quotes and using "+" for concatenating just
two strings. I believe flake8-eyeo should complain about those. Also the
indentation of the second line should align with the opening brace in this case
(not sure if flake8 would complain, but we've basically agreed to use one of the
two styles:

    foo = [bar
               for bar in baz]
    foo = [
        bar
        for bar in baz
    ]

when multiline literals, comprehension expressions or long parameter lists need
to be split over several lines). So probably something like this would be more
"kosher":

            current['urlFilters'] = [v.upper() + '$document'
	    			     for v in value.split()]

[wspee, 2017/08/04 08:41:23]

Done.

+                for v in value.split()]
         else:
             raise Exception("Unknown parameter '%s' in file '%s'" % (key, name))
 
     for text_key in ('title', 'message'):
         def has_default_locale(variant):
             return 'en-US' in variant[text_key]
         if not has_default_locale(notification):
             variants = notification.get('variants', [])
             if not all(map(has_default_locale, variants)):
                 raise Exception('No %s for en-US (default language) '
@@ skipping 21 matching lines @@
                     if not 'inactive' in notification:
                         current_time = datetime.datetime.now()
                         start = notification.pop('start', current_time)
                         end = notification.pop('end', current_time)
                         if not start <= current_time <= end:
                             notification['inactive'] = True
                     notifications.append(notification)
                 except:
                     traceback.print_exc()
     return notifications