tox.ini - Issue 29501558: Issue 5383 - Add tests for the Chrome and Firefox packagers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: tox.ini

Issue 29501558: Issue 5383 - Add tests for the Chrome and Firefox packagers (Closed)

Left Patch Set: Addressing pep8 error from last review Created Aug. 11, 2017, 12:12 p.m.

Right Patch Set: Addressing Vasily's comments Created Oct. 22, 2017, 11:11 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [tox]	1 [tox]

2 envlist = py27	2 envlist = py27

3 skipsdist = true	3 skipsdist = true

4	4

5 [flake8]	5 [flake8]

6 putty-ignore =	6 ignore = D1

7 build.py : A102,A104,A107,A201,A206,A302,E501,E711,F401,N802,N803,N806	7 per-file-ignores =

8 chainedconfigparser.py : A107,E501	8 build.py : A104,A107,A201,A206,A302,E501,E711,N802,N803,N806

9 ensure_dependencies.py : A102,A107,A108,A302,E129,E501,E713,E721,F821	9 chainedconfigparser.py : A107,E501,D205,D208,D400

10 localeTools.py : A103,A104,A107,A108,A206,A301,A302,E129,E501,E711,E713,F401 ,F812,N802,N803,N806	10 ensure_dependencies.py : A102,A107,A108,D400,A302,E129,E501,E713,E721,F821

	11 localeTools.py : A104,A107,A301,A302,E501,E713,F401,N802,N803,N806

11 packager.py : A102,A107,A206,A302,E501,E711,N802,N803,N806	12 packager.py : A102,A107,A206,A302,E501,E711,N802,N803,N806

12 packagerChrome.py : A101,A104,A105,A107,A108,A111,A112,A302,E129,E501,E711,E 713,E731,F401,F841,N802,N803,N806	13 packagerChrome.py : A101,A104,A107,A111,A112,A302,E501,E711,F841,N802,N803,N 806

13 packagerGecko.py : A101,A104,A105,A107,A108,A201,A302,E501,E711,E713,F401,N8 02,N803,N806	14 publicSuffixListUpdater.py : A108,D200,D202,D205,D400,D401,D403,E501,F821,N8 02,N803

14 packagerSafari.py : A101,A107,A301,A302,E501,N802,N803,N806	15 releaseAutomation.py : A102,A107,A108,A302,D202,D400,D401,E501,F401,N803,N80 6

15 publicSuffixListUpdater.py : A108,E501,F821,N802,N803	16

16 releaseAutomation.py : A102,A107,A108,A302,E501,F401,N803,N806	17 [coverage:run]

	18 omit = tests/*

	19

	20 [coverage:report]

	21 show_missing = True

17	22

18 [testenv]	23 [testenv]

	24 whitelist_externals = npm

19 setenv =	25 setenv =

20 PYTHONPATH = {toxinidir}/..	26 PYTHONPATH = {toxinidir}/..

21 deps =	27 deps =

22 pycrypto	28 pycrypto

23 pillow

24 pytest	29 pytest

	30 pytest-cov

25 jinja2	31 jinja2

26 # flake8-putty is not yet compatible with flake8 3.0	32 flake8

27 flake8==2.*	33 flake8-per-file-ignores

28 flake8-putty	34 flake8-docstrings

29 pep8-naming	35 pep8-naming

30 hg+https://hg.adblockplus.org/codingtools#egg=flake8-eyeo&subdirectory=flake 8-eyeo	36 hg+https://hg.adblockplus.org/codingtools#egg=flake8-eyeo&subdirectory=flake 8-eyeo

31 commands =	37 commands =

32 py.test tests --capture=sys	38 npm install --no-package-lock --only=production
Vasily Kuznetsov 2017/08/11 16:46:02 While we're at it, let's add coverage measurement While we're at it, let's add coverage measurement and remove the dot in `py.test`: pytest tests --capture=sys --cov=buildtools --cov-report=term-missing You will need to also add pytest-cov to the dependency list. tlucas 2017/08/14 14:23:18 Done. But py.test is valid too - why did you sugge Show quoted text On 2017/08/11 16:46:02, Vasily Kuznetsov wrote: > While we're at it, let's add coverage measurement and remove the dot in > `py.test`: > > pytest tests --capture=sys --cov=buildtools --cov-report=term-missing > > You will need to also add pytest-cov to the dependency list. Done. But py.test is valid too - why did you suggest omitting the dot?
	39 pytest tests --capture=sys --cov=buildtools

33 flake8	40 flake8

LEFT	RIGHT