README.md - Issue 29501558: Issue 5383 - Add tests for the Chrome and Firefox packagers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: README.md

Issue 29501558: Issue 5383 - Add tests for the Chrome and Firefox packagers (Closed)

Left Patch Set: Adjusting tests to recent changes Created Oct. 11, 2017, 4:01 p.m.

Right Patch Set: Addressing Vasily's comments Created Oct. 22, 2017, 11:11 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 # Buildtools	1 # Buildtools

2	2

3 ## Introduction	3 ## Introduction

4	4

5 Tools used to produce builds and releases of the Adblock Plus browser	5 Tools used to produce builds and releases of the Adblock Plus browser

6 extensions. Intended to be used as a dependency by the extension repositories,	6 extensions. Intended to be used as a dependency by the extension repositories,

7 not directly.	7 not directly.

8	8

9 ## Requirements	9 ## Requirements

10	10

(...skipping 12 matching lines...) Expand all Loading...
23 this repository can be linted and tested using [Tox](https://pypi.python.org/pyp i/tox).	23 this repository can be linted and tested using [Tox](https://pypi.python.org/pyp i/tox).

24	24

25 Once [Tox is installed](https://tox.readthedocs.io/en/latest/install.html) it's	25 Once [Tox is installed](https://tox.readthedocs.io/en/latest/install.html) it's

26 easy to lint and run the tests:	26 easy to lint and run the tests:

27	27

28 tox	28 tox

29	29

30 _(Tox will take care of installing the other dependencies such as flake8 and	30 _(Tox will take care of installing the other dependencies such as flake8 and

31 flake8-abp inside a virtualenv.)_	31 flake8-abp inside a virtualenv.)_

32	32

33 For more information on unit tests please refer to tests/README.md.	33 For more information about the unit tests please refer to tests/README.md.
kzar 2017/10/16 11:17:22 Should read "...about the unit tests..."? Should read "...about the unit tests..."? tlucas 2017/10/17 12:45:39 Done. Show quoted text On 2017/10/16 11:17:22, kzar wrote: > Should read "...about the unit tests..."? Done.
LEFT	RIGHT