Issue 5459 - Add support to show a notification based on the number of ads blocked

lib/notification.js

Index: lib/notification.js
diff --git a/lib/notification.js b/lib/notification.js
index 311e4e881389424155f1a61a3c351a3f69cfaf88..39dfef4047a63ab4cd93023c6d426cd6d9a51a8f 100644
--- a/lib/notification.js
+++ b/lib/notification.js
@@ -304,6 +304,16 @@ let Notification = exports.Notification =
           continue;
       }
 
+      if (typeof notification.blocked_total_min == 'number' &&
+          (typeof Prefs.blocked_total != 'number' ||

[wspee, 2017/07/31 15:16:22]

NOTE: Prefs.blocked_total only exists on webext based extensions but
blocked_total_min/max is supposed to limit the amount of users that receive the
extension so it wouldn't make sense to show the notification is blocked_total
doesn't exists.

You could argue that this is platform specific but it seems to me that Prefs is
intended be platform independent and also firefox-xul will be deprecated
soon-ish so I opted for the simpler implementation.

Let me know what you think?

+          notification.blocked_total_min > Prefs.blocked_total))
+        continue
+
+      if (typeof notification.blocked_total_max == 'number' &&
+          (typeof Prefs.blocked_total != 'number' ||
+          notification.blocked_total_max < Prefs.blocked_total))
+        continue
+
       if (!notificationToShow ||
           getNumericalSeverity(notification) >
             getNumericalSeverity(notificationToShow))