Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/notification.js

Issue 29501607: Issue 5459 - Add support to show a notification based on the number of ads blocked (Closed)
Patch Set: Addressed review comments Created Aug. 23, 2017, 10:10 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/notification.js
diff --git a/test/notification.js b/test/notification.js
index 4a5bc61d1baf99953c245d4441cb02c09944d909..1c56580889d8bfc41adb106c3609f1c6b56d3e2d 100644
--- a/test/notification.js
+++ b/test/notification.js
@@ -174,7 +174,15 @@ for (let [propName, value, result] of [
["platformMaxVersion", "12.0", true],
["platformMaxVersion", "12", true],
["platformMaxVersion", "13", true],
- ["platformMaxVersion", "11", false]
+ ["platformMaxVersion", "11", false],
+ ["blockedTotalMin", "11", false],
+ ["blockedTotalMin", "10", true],
+ ["blockedTotalMax", "10", true],
+ ["blockedTotalMax", "1", false],
+ ["locales", ["en-US"], true],
+ ["locales", ["en-US", "de-DE"], true],
+ ["locales", ["de-DE"], false],
+ ["locales", ["en-GB", "de-DE"], false]
])
{
exports.testTargetSelection[`${propName}=${value}`] = function(test)
@@ -213,7 +221,8 @@ for (let [[propName1, value1, result1], [propName2, value2, result2]] of pairs([
["platform", "chromium", true],
["platform", "gecko", false],
["platformMinVersion", "12", true],
- ["platformMinVersion", "13", false]
+ ["platformMinVersion", "13", false],
+ ["unkown", "unknown", false]
]))
{
exports.testMultipleTargets[`${propName1}=${value1},${propName2}=${value2}`] = function(test)
« lib/notification.js ('K') | « lib/notification.js ('k') | test/stub-modules/prefs.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld