#2498 - Provide systemd unit for spawn-fcgi

modules/spawn_fcgi/manifests/init.pp

 # Class: spawn_fcgi
 #
 # This class manage spawn-fcgi installation and configuration.
 #
 # Use spawn_fcgi::pool for configuring spawn-fcgi pools
 # Use spawn_fcgi::php-pool to configure a preconfigured php-pool
 #
 class spawn_fcgi {
 
     package { 'spawn-fcgi': ensure => installed }
 
     service { 'spawn-fcgi':
         ensure      => running,
         hasstatus   => true,
         enable      => true,
         require     => [
-          File['/etc/init.d/spawn-fcgi'],
-          File['/etc/systemd/system/spawn-fcgi.service'],
-          ],

[mathias, 2017/08/01 22:21:18]

That closing bracket is one indent level too deep.

[f.nicolaisen, 2017/08/02 07:51:48]

Acknowledged.

-    }
-
-    file { '/etc/systemd/system/spawn-fcgi.service':
-        ensure  => present,
-        owner   => root,
-        group   => root,
-        mode    => '0755',
-        source => 'puppet:///modules/spawn_fcgi/spawn-fcgi.service',
-        require => Package['spawn-fcgi'],
+            File['/etc/init.d/spawn-fcgi'],
+            File['/etc/systemd/system/spawn-fcgi.service'],
+        ],
     }
 
     file { '/etc/init.d/spawn-fcgi':
         ensure  => present,
         owner   => root,
         group   => root,
         mode    => '0755',
         content => template('spawn_fcgi/init-spawn-fcgi.erb'),
         require => Package['spawn-fcgi'],
     }
 
+    file { [
+        '/etc/systemd',
+        '/etc/systemd/system',
+    ]:
+        ensure => 'directory',
+    }
+
+    # #2498: As systemd is not reliably enabling legacy sysvinit scripts, we
+    # provide the # unit file (as generated by systemd when enabling the
+    # service manually). This workaround can be considered for removal with
+    # systemd 220, or when the package ships with its own systemd unit.
+    file { '/etc/systemd/system/spawn-fcgi.service':
+        ensure  => present,
+        owner => root,
+        group => root,
+        mode => '0755',
+        source => 'puppet:///modules/spawn_fcgi/spawn-fcgi.service',
+        require => [
+            File['/etc/systemd/system'],
+            Package['spawn-fcgi'],
+        ]
+    }
+
     file { '/etc/spawn-fcgi':
         ensure  => directory,
         require => Package['spawn-fcgi'],
     }
 }