Issue 4096 - remove qunit/* from other builds than devenv

packagerChrome.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import errno
 import io
 import json
 import os
 import re
 from StringIO import StringIO
@@ skipping 374 matching lines @@
     files['manifest.json'] = createManifest(params, files)
     if type == 'chrome':
         fixTranslationsForCWS(files)
 
     if devenv:
         import buildtools
         import random
         files.read(os.path.join(buildtools.__path__[0], 'chromeDevenvPoller__.js'), relpath='devenvPoller__.js')
         files['devenvVersion__'] = str(random.random())
 
-    if metadata.has_option('general', 'testScripts'):
-        files['qunit/index.html'] = createScriptPage(params, 'testIndex.html.tmpl',
-                                                     ('general', 'testScripts'))
+        if metadata.has_option('general', 'testScripts'):
+            files['qunit/index.html'] = createScriptPage(
+                    params, 'testIndex.html.tmpl', ('general', 'testScripts'))

[Vasily Kuznetsov, 2017/08/02 17:07:56]

If you run tox, flake8 fails on this line. This can be fixed by un-indenting it
one step, but it would be preferable (although not yet documented in
https://adblockplus.org/coding-style#python) to do something like this:

            files['qunit/index.html'] = createScriptPage(
                params, 'testIndex.html.tmpl', ('general', 'testScripts')
            )

[tlucas, 2017/08/03 10:00:22]

Done - also got vim-flake8 running with consindering tox.ini config

 
     zipdata = files.zipToString()
     signature = None
     pubkey = None
     if keyFile != None:
         signature = signBinary(zipdata, keyFile)
         pubkey = getPublicKey(keyFile)
     writePackage(outFile, pubkey, signature, zipdata)