Issue 4096 - remove qunit/* from other builds than devenv

packagerChrome.py

Index: packagerChrome.py
diff --git a/packagerChrome.py b/packagerChrome.py
index 5d3ecca9998c2b786aba7ad8f5305ee54688ca3a..b4c6aaa227c0f127f8abb8b9e06bab87f833c21a 100644
--- a/packagerChrome.py
+++ b/packagerChrome.py
@@ -392,9 +392,9 @@ def createBuild(baseDir, type='chrome', outFile=None, buildNum=None, releaseBuil
         files.read(os.path.join(buildtools.__path__[0], 'chromeDevenvPoller__.js'), relpath='devenvPoller__.js')
         files['devenvVersion__'] = str(random.random())
 
-    if metadata.has_option('general', 'testScripts'):
-        files['qunit/index.html'] = createScriptPage(params, 'testIndex.html.tmpl',
-                                                     ('general', 'testScripts'))
+        if metadata.has_option('general', 'testScripts'):
+            files['qunit/index.html'] = createScriptPage(
+                    params, 'testIndex.html.tmpl', ('general', 'testScripts'))

[Vasily Kuznetsov, 2017/08/02 17:07:56]

If you run tox, flake8 fails on this line. This can be fixed by un-indenting it
one step, but it would be preferable (although not yet documented in
https://adblockplus.org/coding-style#python) to do something like this:

            files['qunit/index.html'] = createScriptPage(
                params, 'testIndex.html.tmpl', ('general', 'testScripts')
            )

[tlucas, 2017/08/03 10:00:22]

Done - also got vim-flake8 running with consindering tox.ini config

 
     zipdata = files.zipToString()
     signature = None