pages/forms/advanced.html - Issue 29510560: Issue 4633 - Default form styles

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: pages/forms/advanced.html

Issue 29510560: Issue 4633 - Default form styles (Closed) Base URL: https://hg.adblockplus.org/website-defaults

Left Patch Set: Rebase on website-defaults with reset and namespaced content Created Sept. 13, 2017, 7:39 a.m.

Right Patch Set: Addressed NITs Created Sept. 19, 2017, 8:07 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 title=Advanced Form Fields	1 title=Advanced Form Fields

2	2

3 <h1>Advanced Form Fields</h1>	3 <h1>Advanced Form Fields</h1>

4 <p>Default styles for advanced form elements.</p>	4 <p>Default styles for advanced form elements.</p>

5	5

6 <nav>	6 <nav>

7 <ol>	7 <ol>

8 <li><a href="#advanced-text">Advanced text</a></li>	8 <li><a href="#advanced-text">Advanced text</a></li>

9 <li><a href="#media">Media</a></li>

10 </ol>	9 </ol>

11 </nav>	10 </nav>

12	11

13 <section id="advanced-text">	12 <section id="advanced-text">

14 <h2>Advanced text</h2>	13 <h2>Advanced text</h2>

15 <p><input type="search" placeholder="Search terms" /></p>	14 <p><input type="search" placeholder="Search terms" /></p>

16 <p><input type="tel" placeholder="+55-55-555-5555" /></p>	15 <p><input type="tel" placeholder="+55-55-555-5555" /></p>

17 <p><input type="url" placeholder="example.com" /></p>	16 <p><input type="url" placeholder="example.com" /></p>

18 <p><input type="email" placeholder="user@example.com" /></p>	17 <p><input type="email" placeholder="user@example.com" /></p>

19 <p><input type="password" placeholder="Password" /></p>	18 <p><input type="password" placeholder="Password" /></p>

20 <p><input type="date" placeholder="Date" /></p>	19 <p><input type="date" placeholder="Date" /></p>

21 <p><input type="time" placeholder="Time" /></p>	20 <p><input type="time" placeholder="Time" /></p>

22 <p><input type="datetime-local" placeholder="Datetime Local" /></p>	21 <p><input type="datetime-local" placeholder="Datetime Local" /></p>

23 <p><input type="number" placeholder="5" /></p>	22 <p><input type="number" placeholder="5" /></p>

24 </section>	23 </section>

25

26 <section id="advanced-text">
juliandoucette 2017/09/18 13:13:21 NIT: I think that we should exclude the file input NIT: I think that we should exclude the file input until we use it (which we may never). ire 2017/09/19 08:06:48 Makes sense. Done. Show quoted text On 2017/09/18 13:13:21, juliandoucette wrote: > NIT: I think that we should exclude the file input until we use it (which we may > never). Makes sense. Done.
27 <h2>Media</h2>

28 <p>

29 <label for="file">File</label>

30 <input id="file" type="file" />

31 </p>

32 </section>

LEFT	RIGHT