Issue 5393 - fix libraries order issue when linking of V8 mksnapshot for linux host

make_gyp_wrapper.py

 #!/usr/bin/env python
 # coding: utf-8
 """This script fixes the support of manually compiled static libraries for
 android NDK build system.
 
 Issue:
 Let's say there are some manually compiled libraries specified in
 link_settings.libraries or in ldflags of a gyp file. In this case ndk-build
 passes them to a linker after system libraries, like c++_static, and
 as the result linker cannot find functions from system libraries.
@@ skipping 55 matching lines @@
 However merely to reduce any potential influence we override
 MakefileWriter.WriteAndroidNdkModuleRule to define manually compiled libraries
 and override WriteList only while we are in the WriteAndroidNdkModuleRule method.
 The aim of the latter method is exactly to write Rules for ndk-build and it is
 called at the end of Write. However, since WriteAndroidNdkModuleRule lacks
 required information, we override method Write to store configurations as
 _abp_configs attribute of instance of MakefileWriter.
 """
 
 import os
+import platform
 import sys
 import types
 
 base_dir = os.path.abspath(os.path.dirname(__file__))
 sys.path.append(os.path.join(base_dir, 'third_party', 'gyp', 'pylib'))
 import gyp
 from gyp.generator.make import MakefileWriter, QuoteIfNecessary
 
 
 orig_MakefileWriter_Write = MakefileWriter.Write
@@ skipping 26 matching lines @@
             value_list.append("${ABP_STATIC_LIBRARIES_${BUILDTYPE}}")
         orig_WriteList(value_list, variable, prefix, quoter)
     self.WriteList = types.MethodType(overridden_WriteList, self)
     orig_MakefileWriter_WriteAndroidNdkModuleRule(self, module_name, all_sources, link_deps)
     self.WriteList = orig_WriteList
 
 MakefileWriter.Write = overridden_Write
 MakefileWriter.WriteAndroidNdkModuleRule = overridden_WriteAndroidNdkModuleRule
 
 # Issue 5393
-# replace $(LD_INPUTS) by "-Wl,--start-group $(LD_INPUTS) -Wl,--end-group" but only for cmd_link_host

[sergei, 2017/08/09 12:53:41]

It concerns the following line:
https://github.com/adblockplus/gyp/blob/8ffe7e7b1b82890a7e9ea21176bf039b6c531....
LINK_COMMANDS_ANDROID is used to fill generic makefiles like
build/Makefile.android_arm.release

-gyp.generator.make.LINK_COMMANDS_ANDROID = \
-    gyp.generator.make.LINK_COMMANDS_ANDROID[:663] + \
-    "-Wl,--start-group $(LD_INPUTS) -Wl,--end-group" + \
-    gyp.generator.make.LINK_COMMANDS_ANDROID[675:]
+# replace $(LD_INPUTS) by "-Wl,--start-group $(LD_INPUTS) -Wl,--end-group" but
+# only for cmd_link_host and only on linux.
+print platform.system()
+if platform.system() == "Linux":
+    gyp.generator.make.LINK_COMMANDS_ANDROID = \
+        gyp.generator.make.LINK_COMMANDS_ANDROID[:663] + \
+        "-Wl,--start-group $(LD_INPUTS) -Wl,--end-group" + \
+        gyp.generator.make.LINK_COMMANDS_ANDROID[675:]
 
 if __name__ == '__main__':
     gyp.main(sys.argv[1:])