Makefile - Issue 29510583: Issue 5393 - fix libraries order issue when linking of V8 mksnapshot for linux host

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: Makefile

Issue 29510583: Issue 5393 - fix libraries order issue when linking of V8 mksnapshot for linux host (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Patch Set: Created Aug. 9, 2017, 12:41 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Makefile

diff --git a/Makefile b/Makefile

index b738306f82cd442b5660e8c7a27b851685868e95..41741fe9b94ee29203c34e5b4097b05b568d6825 100644

--- a/Makefile

+++ b/Makefile

@@ -96,7 +96,7 @@ v8_android_multi: ensure_dependencies

cd third_party/v8 && GYP_GENERATORS=make-android \

GYP_DEFINES="${GYP_PARAMETERS} v8_target_arch=${ANDROID_ARCH}" \

PYTHONPATH="${V8_DIR}tools/generate_shim_headers:${V8_DIR}gypfiles:${PYTHONPATH}" \

- tools/gyp/gyp \

+ python ../../make_gyp_wrapper.py \

--generator-output=../../build src/v8.gyp \

-Igypfiles/standalone.gypi \

--depth=. \

« no previous file with comments | « no previous file | make_gyp_wrapper.py » ('j') | make_gyp_wrapper.py » ('J')