Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/browser/_bootstrap.js

Issue 29517687: Issue 5079, 5516 - Use webpack for browser tests, modules for content scripts (Closed)
Patch Set: Addressed Wladimir's and Hubert's initial feedback Created Aug. 17, 2017, 12:36 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/browser/_bootstrap.js
diff --git a/test/browser/_bootstrap.js b/test/browser/_bootstrap.js
index 969c62ec1d05f42f9ba68ee72abc33c1fa23e5fe..c49d4134abb07cf4d899e46af44156edcfe09c25 100644
--- a/test/browser/_bootstrap.js
+++ b/test/browser/_bootstrap.js
@@ -18,124 +18,79 @@
"use strict";
/* globals nodeunit */
+require("nodeunit");
-(function(nodeunitUrl, ...moduleUrls)
+function runTests(moduleNames)
{
- function loadScript(doc, url)
+ function bold(str)
{
- return new Promise((resolve, reject) =>
- {
- let script = doc.createElement("script");
- script.src = url;
- script.onload = resolve;
- doc.head.appendChild(script);
- });
+ return "\u001B[1m" + str + "\u001B[22m";
}
- function loadModules(urls)
+ function ok(str)
{
- let modules = {};
-
- return (function loadNext()
- {
- if (urls.length)
- {
- // Load each module into a new frame so that their scopes don't clash
- let frame = document.createElement("iframe");
- document.body.appendChild(frame);
-
- let wnd = frame.contentWindow;
- wnd.loadScript = url => loadScript(wnd.document, url);
- wnd.exports = {};
- wnd.module = {exports: wnd.exports};
-
- let url = urls.shift();
- let name = url.split("/").pop();
- return wnd.loadScript(url).then(() =>
- {
- modules[name] = nodeunit.testCase(wnd.module.exports);
- return loadNext();
- });
- }
-
- return Promise.resolve(modules);
- })();
+ return "\u001B[32m" + str + "\u001B[39m";
}
- function runTests(modules)
+ function error(str)
{
- function bold(str)
- {
- return "\u001B[1m" + str + "\u001B[22m";
- }
+ return "\u001B[31m" + str + "\u001B[39m";
+ }
- function ok(str)
- {
- return "\u001B[32m" + str + "\u001B[39m";
- }
+ let tests = {};
+ for (let module of moduleNames)
+ tests[module] = nodeunit.testCase(require("./" + module + ".js"));
- function error(str)
- {
- return "\u001B[31m" + str + "\u001B[39m";
- }
+ return new Promise((resolve, reject) =>
+ {
+ nodeunit.runModules(tests, {
+ moduleStart(name)
+ {
+ console.log(bold(name));
+ },
+ testDone(name, assertions)
+ {
+ let errors = assertions.filter(assertion => assertion.failed())
+ .map(assertion => assertion.error);
- return new Promise((resolve, reject) =>
- {
- nodeunit.runModules(modules, {
- moduleStart(name)
- {
- console.log(bold(name));
- },
- testDone(name, assertions)
+ if (errors.length == 0)
+ console.log("\u2714 " + name);
+ else
{
- let errors = assertions.filter(assertion => assertion.failed())
- .map(assertion => assertion.error);
-
- if (errors.length == 0)
- console.log("\u2714 " + name);
- else
+ console.log(error("\u2716 " + name) + "\n");
+ errors.forEach(e =>
{
- console.log(error("\u2716 " + name) + "\n");
- errors.forEach(e =>
- {
- if (e.stack)
- console.log(e.stack);
- else
- console.log(String(e));
- console.log("");
- });
- }
- },
- done(assertions)
+ if (e.stack)
+ console.log(e.stack);
+ else
+ console.log(String(e));
+ console.log("");
+ });
+ }
+ },
+ done(assertions)
+ {
+ let failures = assertions.filter(assertion => assertion.failed());
+ if (failures.length)
{
- let failures = assertions.filter(assertion => assertion.failed());
- if (failures.length)
- {
- console.log(
- "\n" +
- bold(error("FAILURES: ")) +
- failures.length + "/" + assertions.length + " assertions failed"
- );
- }
- else
- {
- console.log(
- "\n" + bold(ok("OK: ")) +
- assertions.length + " assertions"
- );
- }
-
- resolve();
+ console.log(
+ "\n" +
+ bold(error("FAILURES: ")) +
+ failures.length + "/" + assertions.length + " assertions failed"
+ );
+ }
+ else
+ {
+ console.log(
+ "\n" + bold(ok("OK: ")) +
+ assertions.length + " assertions"
+ );
}
- });
- });
- }
- return loadScript(document, nodeunitUrl).then(() =>
- {
- return loadModules(moduleUrls);
- }).then(modules =>
- {
- return runTests(modules);
+ resolve();
+ }
+ });
});
-});
+}
+
+module.exports = runTests;
« no previous file with comments | « package.json ('k') | test/browser/elemHideEmulation.js » ('j') | test_runner.js » ('J')

Powered by Google App Engine
This is Rietveld