Left: | ||
Right: |
OLD | NEW |
---|---|
1 // This file is part of help.eyeo.com. | 1 // This file is part of help.eyeo.com. |
2 // Copyright (C) 2017 Eyeo GmbH | 2 // Copyright (C) 2017 Eyeo GmbH |
3 // | 3 // |
4 // help.eyeo.com is free software: you can redistribute it and/or modify | 4 // help.eyeo.com is free software: you can redistribute it and/or modify |
5 // it under the terms of the GNU General Public License as published by | 5 // it under the terms of the GNU General Public License as published by |
6 // the Free Software Foundation, either version 3 of the License, or | 6 // the Free Software Foundation, either version 3 of the License, or |
7 // (at your option) any later version. | 7 // (at your option) any later version. |
8 // | 8 // |
9 // help.eyeo.com is distributed in the hope that it will be useful, | 9 // help.eyeo.com is distributed in the hope that it will be useful, |
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of | 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of |
(...skipping 22 matching lines...) Expand all Loading... | |
33 | 33 |
34 .section | 34 .section |
35 { | 35 { |
36 margin-bottom: $lg; | 36 margin-bottom: $lg; |
37 | 37 |
38 @media (min-width: $phablet-breakpoint) | 38 @media (min-width: $phablet-breakpoint) |
39 { | 39 { |
40 margin-bottom: $xl; | 40 margin-bottom: $xl; |
41 } | 41 } |
42 } | 42 } |
43 | |
44 .section-accent | |
juliandoucette
2017/09/26 15:37:56
I think that I have been confused about the meanin
ire
2017/09/28 09:43:44
1. I think I have been confused as well, and I can
juliandoucette
2017/10/09 22:00:38
I disagree. It would be secondary. And the product
ire
2017/10/10 18:36:29
Isn't "brand" "primary"? Haha. I think we should c
| |
45 { | |
46 padding-top: $xl; | |
47 padding-bottom: $xl; | |
48 background-image: url("/img/png/accent-bg.png"); | |
juliandoucette
2017/09/26 15:37:55
Can we do this with SVG or triangular borders? (th
ire
2017/09/28 09:43:45
Perhaps, but what would be the benefit in this cas
juliandoucette
2017/10/09 22:00:38
[smaller file size, less blur]
(This is a NIT)
ire
2017/10/10 18:36:27
Fair points. I think I will consider this somethin
| |
49 background-size: 100%; | |
50 background-repeat: no-repeat; | |
51 background-position: center 0; | |
52 } | |
53 | |
54 .section-accent .horizontal-list li | |
55 { | |
56 margin-right: $md; | |
57 font-weight: $bold-weight; | |
58 text-transform: uppercase; | |
59 } | |
juliandoucette
2017/09/26 15:37:55
All links are supposed to be blue; aren't they?
ire
2017/09/28 09:43:45
Done.
| |
60 | |
61 [dir="rtl"] | |
juliandoucette
2017/09/26 15:37:56
Note: You could set a negative margin on the list
ire
2017/09/28 09:43:45
Nice trick! But the margins between the list items
juliandoucette
2017/10/09 22:00:38
I was counting on the margins not collapsing.
Ass
ire
2017/10/10 18:36:27
Done.
ire
2017/10/10 18:36:28
Ah I see, I think I was using $md when I tried and
| |
62 { | |
63 .section-accent .horizontal-list li | |
64 { | |
65 margin-right: 0; | |
66 margin-left: $md; | |
67 } | |
68 } | |
69 | |
70 .container-sm | |
juliandoucette
2017/09/26 15:37:56
NIT/Suggest: Doesn't ".tablet-width" make more sen
ire
2017/09/28 09:43:45
Yes it makes a lot more sense haha. Done.
(We sho
juliandoucette
2017/10/09 22:00:38
Acknowledged.
| |
71 { | |
72 width: $tablet-width; | |
73 } | |
OLD | NEW |