Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: static/scss/layout/_body.scss

Issue 29519587: Issue 5534 - Create Contact Section for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Add footer block for contact section Created Sept. 25, 2017, 2:01 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: static/scss/layout/_body.scss
===================================================================
--- a/static/scss/layout/_body.scss
+++ b/static/scss/layout/_body.scss
@@ -35,8 +35,39 @@
{
margin-bottom: $lg;
@media (min-width: $phablet-breakpoint)
{
margin-bottom: $xl;
}
}
+
+.section-accent
juliandoucette 2017/09/26 15:37:56 I think that I have been confused about the meanin
ire 2017/09/28 09:43:44 1. I think I have been confused as well, and I can
juliandoucette 2017/10/09 22:00:38 I disagree. It would be secondary. And the product
ire 2017/10/10 18:36:29 Isn't "brand" "primary"? Haha. I think we should c
+{
+ padding-top: $xl;
+ padding-bottom: $xl;
+ background-image: url("/img/png/accent-bg.png");
juliandoucette 2017/09/26 15:37:55 Can we do this with SVG or triangular borders? (th
ire 2017/09/28 09:43:45 Perhaps, but what would be the benefit in this cas
juliandoucette 2017/10/09 22:00:38 [smaller file size, less blur] (This is a NIT)
ire 2017/10/10 18:36:27 Fair points. I think I will consider this somethin
+ background-size: 100%;
+ background-repeat: no-repeat;
+ background-position: center 0;
+}
+
+.section-accent .horizontal-list li
+{
+ margin-right: $md;
+ font-weight: $bold-weight;
+ text-transform: uppercase;
+}
juliandoucette 2017/09/26 15:37:55 All links are supposed to be blue; aren't they?
ire 2017/09/28 09:43:45 Done.
+
+[dir="rtl"]
juliandoucette 2017/09/26 15:37:56 Note: You could set a negative margin on the list
ire 2017/09/28 09:43:45 Nice trick! But the margins between the list items
juliandoucette 2017/10/09 22:00:38 I was counting on the margins not collapsing. Ass
ire 2017/10/10 18:36:27 Done.
ire 2017/10/10 18:36:28 Ah I see, I think I was using $md when I tried and
+{
+ .section-accent .horizontal-list li
+ {
+ margin-right: 0;
+ margin-left: $md;
+ }
+}
+
+.container-sm
juliandoucette 2017/09/26 15:37:56 NIT/Suggest: Doesn't ".tablet-width" make more sen
ire 2017/09/28 09:43:45 Yes it makes a lot more sense haha. Done. (We sho
juliandoucette 2017/10/09 22:00:38 Acknowledged.
+{
+ width: $tablet-width;
+}

Powered by Google App Engine
This is Rietveld