Issue 3916 - Supporting Adding filter lists via URL

adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Subscriptions.java

Index: adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Subscriptions.java
===================================================================
--- a/adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Subscriptions.java
+++ b/adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Subscriptions.java
@@ -198,16 +198,18 @@ final class Subscriptions
         // See https://issues.adblockplus.org/ticket/4772
         if (!filter.matches(UNSUPPORTED_FILTERS_REGEX))
         {
           w.write(filter);
           w.write('\n');
         }
         else
         {
+          w.write(filter);
+          w.write('\n');

[diegocarloslima, 2017/09/22 17:43:43]

We shouldn't revert this temporary fix in this ticket. Also, we need first to
align with Samsung if almost no users are still using an old version of the
browser that doesn't contain the edge case crash fix.

[jens, 2017/09/26 10:25:02]

Sorry, I don't know how these two lines slipped into the patch set. That was
definitely not on purpose!

           Log.d(TAG, "Ignoring unsupported filter: " + filter);
         }
       }
     }
   }
 
   public Subscription add(final Subscription sub)
   {
@@ -215,16 +217,21 @@ final class Subscriptions
     if (!this.subscriptions.containsKey(id))
     {
       this.subscriptions.put(id, sub);
       return sub;
     }
     return this.subscriptions.get(id);
   }
 
+  public boolean remove(final String id)
+  {
+    return this.subscriptions.remove(id) != null;
+  }
+
   public static Subscriptions initialize(final Engine engine, final File appFolder,
       final File cacheFolder)
   {
     final Subscriptions subs = new Subscriptions(engine, appFolder, cacheFolder);
 
     subs.subscriptionFolder.mkdirs();
     subs.cacheFolder.mkdirs();