Unified Diff: lib/stats.js
Issue 29532772:
Issue 5588 - Clear badge text only if zero hits (Closed)
Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set:
Created Aug. 31, 2017, 5:46 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/stats.js |
| =================================================================== |
| --- a/lib/stats.js |
| +++ b/lib/stats.js |
| @@ -34,17 +34,18 @@ |
| */ |
| exports.getBlockedPerPage = page => blockedPerPage.get(page) || 0; |
| // Chrome automatically clears the browser action badge text when the URL of |
| // the tab is updated, but Firefox doesn't. |
| // https://bugzilla.mozilla.org/show_bug.cgi?id=1395074 |
| ext.pages.onLoading.addListener(page => |
| { |
| - page.browserAction.setBadge(); |
| + if (!blockedPerPage.get(page)) |
| + page.browserAction.setBadge(); |
| }); |
| FilterNotifier.on("filter.hitCount", (filter, newValue, oldValue, page) => |
| { |
| if (!(filter instanceof BlockingFilter) || !page) |
| return; |
| Prefs.blocked_total++; |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
