Issue 5508 - implement InMemoryFS for tests

test/FilterEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 54 matching lines @@
 
     FilterEngine& GetFilterEngine()
     {
       return platform->GetFilterEngine();
     }
   };
 
   typedef FilterEngineTestGeneric<LazyFileSystem, AdblockPlus::DefaultLogSystem> FilterEngineTest;
   typedef FilterEngineTestGeneric<NoFilesFileSystem, LazyLogSystem> FilterEngineTestNoData;
 
-  class FilterEngineWithFreshFolder : public BaseJsTest
+  class FilterEngineWithInMemoryFS : public BaseJsTest
   {
+    LazyFileSystem* fileSystem;
   protected:
-    FileSystemPtr fileSystem;
-    std::list<SchedulerTask> fileSystemTasks;
-
-    void SetUp() override
-    {
-      fileSystem = CreateDefaultFileSystem([this](const SchedulerTask& task)
-      {
-        fileSystemTasks.emplace_back(task);
-      });
-      // Since there is neither in memory FS nor functionality to work with
-      // directories use the hack: manually clean the directory.
-      removeFileIfExists("patterns.ini");
-      removeFileIfExists("prefs.json");
-    }
     void InitPlatformAndAppInfo(const AppInfo& appInfo = AppInfo())
     {
       ThrowingPlatformCreationParameters platformParams;
       platformParams.logSystem.reset(new LazyLogSystem());
       platformParams.timer.reset(new NoopTimer());
-      platformParams.fileSystem = fileSystem;
+      platformParams.fileSystem.reset(fileSystem = new InMemoryFileSystem());
       platformParams.webRequest.reset(new NoopWebRequest());
       platform.reset(new Platform(std::move(platformParams)));
       platform->SetUpJsEngine(appInfo);
     }
 
     FilterEngine& CreateFilterEngine(const FilterEngine::CreationParameters& creationParams = FilterEngine::CreationParameters())
     {
-      bool isFilterEngineReady = false;
-      platform->CreateFilterEngineAsync(creationParams, [&isFilterEngineReady](const FilterEngine& filterEngine)
-      {
-        isFilterEngineReady = true;
-      });
-      while (!isFilterEngineReady && !fileSystemTasks.empty())
-      {
-        (*fileSystemTasks.begin())();
-        fileSystemTasks.pop_front();
-      }
+      ::CreateFilterEngine(*fileSystem, *platform, creationParams);
       return platform->GetFilterEngine();
     }
-
-    void TearDown() override
-    {
-      removeFileIfExists("patterns.ini");
-      removeFileIfExists("prefs.json");
-      fileSystem.reset();
-      BaseJsTest::TearDown();
-    }
-    void removeFileIfExists(const std::string& fileName)
-    {
-      bool hasStatRun = false;
-      bool doesFileExists;
-      fileSystem->Stat(fileName, [&hasStatRun, &doesFileExists](const IFileSystem::StatResult& stats, const std::string& error)
-      {
-        EXPECT_TRUE(error.empty()) << error;
-        doesFileExists = stats.exists;
-        hasStatRun = true;
-      });
-      while (!hasStatRun && !fileSystemTasks.empty())
-      {
-        (*fileSystemTasks.begin())();
-        fileSystemTasks.pop_front();
-      }
-
-      if (!doesFileExists)
-        return;
-
-      bool hasRemoveRun = false;
-      fileSystem->Remove(fileName, [&hasRemoveRun](const std::string& error)
-      {
-        EXPECT_TRUE(error.empty()) << error;
-        hasRemoveRun = true;
-      });
-      while (!hasStatRun && !fileSystemTasks.empty())
-      {
-        (*fileSystemTasks.begin())();
-        fileSystemTasks.pop_front();
-      }
-    }
   };
 
   class FilterEngineIsSubscriptionDownloadAllowedTest : public BaseJsTest
   {
   protected:
     typedef std::vector<std::pair<bool, std::string>> ConnectionTypes;
     DelayedWebRequest::SharedTasks webRequestTasks;
     DelayedTimer::SharedTasks timerTasks;
     FilterEngine::CreationParameters createParams;
     ConnectionTypes capturedConnectionTypes;
@@ skipping 526 matching lines @@
 
   ASSERT_TRUE(filterEngine.IsElemhideWhitelisted(
       "http://example.com",
       documentUrls1));
 
   ASSERT_FALSE(filterEngine.IsElemhideWhitelisted(
       "http://example.co.uk",
       documentUrls1));
 }
 
-TEST_F(FilterEngineWithFreshFolder, LangAndAASubscriptionsAreChosenOnFirstRun)
+TEST_F(FilterEngineWithInMemoryFS, LangAndAASubscriptionsAreChosenOnFirstRun)
 {
   AppInfo appInfo;
   appInfo.locale = "zh";
   const std::string langSubscriptionUrl = "https://easylist-downloads.adblockplus.org/easylistchina+easylist.txt";
   InitPlatformAndAppInfo(appInfo);
   auto& filterEngine = CreateFilterEngine();
   const auto subscriptions = filterEngine.GetListedSubscriptions();
   ASSERT_EQ(2u, subscriptions.size());
   std::unique_ptr<Subscription> aaSubscription;
   std::unique_ptr<Subscription> langSubscription;
   if (subscriptions[0].IsAA())
   {
     aaSubscription.reset(new Subscription(subscriptions[0]));
     langSubscription.reset(new Subscription(subscriptions[1]));
   }
   else if (subscriptions[1].IsAA())
   {
     aaSubscription.reset(new Subscription(subscriptions[1]));
     langSubscription.reset(new Subscription(subscriptions[0]));
   }
   ASSERT_NE(nullptr, aaSubscription);
   ASSERT_NE(nullptr, langSubscription);
   EXPECT_EQ(langSubscriptionUrl, langSubscription->GetProperty("url").AsString());
   EXPECT_TRUE(filterEngine.IsAAEnabled());
 }
 
-TEST_F(FilterEngineWithFreshFolder, DisableSubscriptionsAutoSelectOnFirstRun)
+TEST_F(FilterEngineWithInMemoryFS, DisableSubscriptionsAutoSelectOnFirstRun)
 {
   InitPlatformAndAppInfo();
   FilterEngine::CreationParameters createParams;
   createParams.preconfiguredPrefs.emplace("first_run_subscription_auto_select", GetJsEngine().NewValue(false));
   auto& filterEngine = CreateFilterEngine(createParams);
   const auto subscriptions = filterEngine.GetListedSubscriptions();
   EXPECT_EQ(0u, subscriptions.size());
   EXPECT_FALSE(filterEngine.IsAAEnabled());
 }
 
@@ skipping 324 matching lines @@
     std::string testConnection = "test connection";
     GetFilterEngine().SetAllowedConnectionType(&testConnection);
     auto subscription = EnsureExampleSubscriptionAndForceUpdate("subB");
     EXPECT_EQ("synchronize_ok", subscription.GetProperty("downloadStatus").AsString());
     EXPECT_EQ(1u, subscription.GetProperty("filters").AsList().size());
     ASSERT_EQ(1u, capturedConnectionTypes.size());
     EXPECT_TRUE(capturedConnectionTypes[0].first);
     EXPECT_EQ(testConnection, capturedConnectionTypes[0].second);
   }
 }