.eslintignore - Issue 29545700: Issue 5685 - Pass ESLint

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: .eslintignore

Issue 29545700: Issue 5685 - Pass ESLint (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/

Patch Set: Created Sept. 15, 2017, 7:38 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 lib/punycode.js	1 lib/punycode.js

2 lib/publicSuffixList.js	2 lib/publicSuffixList.js

	3 lib/basedomain.js
	hub 2017/09/15 19:44:00 This is a third-party file. Leaving it alone for n This is a third-party file. Leaving it alone for now. sergei 2017/09/18 07:59:04 Acknowledged. Show quoted text On 2017/09/15 19:44:00, hub wrote: > This is a third-party file. Leaving it alone for now. Acknowledged.
	4 lib/compat.js
	hub 2017/09/15 19:44:00 This one mostly pass but has some issues: it expor This one mostly pass but has some issues: it export some functions, but since there is a global env "commonjs" exported can't be used. And one can't disable env. sergei 2017/09/18 07:59:04 If it's because of definition of `require` then wo Show quoted text On 2017/09/15 19:44:00, hub wrote: > This one mostly pass but has some issues: it export some functions, but since > there is a global env "commonjs" exported can't be used. And one can't disable > env. If it's because of definition of `require` then would it be possible to move it into a separate file and ignore only this separate file? Maybe it's for another commit, though. hub 2017/09/18 12:43:04 eventually we'll move to webpack and this will be Show quoted text On 2017/09/18 07:59:04, sergei wrote: > On 2017/09/15 19:44:00, hub wrote: > > This one mostly pass but has some issues: it export some functions, but since > > there is a global env "commonjs" exported can't be used. And one can't disable > > env. > > If it's because of definition of `require` then would it be possible to move it > into a separate file and ignore only this separate file? > Maybe it's for another commit, though. eventually we'll move to webpack and this will be made obsolete. in the mean time we can do that.
OLD	NEW

« no previous file with comments | « no previous file | lib/.eslintrc.json » ('j') | lib/.eslintrc.json » ('J')