Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: .eslintignore
Issue
29545700
:
Issue 5685 - Pass ESLint (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Address review comments
Created Sept. 18, 2017, 12:42 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Address review comments
Right:
Patch Set 1: None
Patch Set 2: Address review comments
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.eslintignore
lib/.eslintrc.json
lib/api.js
lib/compat.js
lib/elemHideHitRegistration.js
lib/filterUpdateRegistration.js
lib/info.js
lib/init.js
lib/io.js
lib/notificationShowRegistration.js
lib/prefs.js
lib/updater.js
lib/utils.js
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
lib/.eslintrc.json »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 lib/punycode.js
1 lib/punycode.js
2 lib/publicSuffixList.js
2 lib/publicSuffixList.js
3
lib/basedomain.js
4
lib/compat.js
OLD
NEW
« no previous file with comments
|
« no previous file
|
lib/.eslintrc.json »
('j') |
no next file with comments »
Edit Message
Issue 29545700: Issue 5685 - Pass ESLint (Closed)
Created Sept. 15, 2017, 7:38 p.m. by hub
Modified Sept. 18, 2017, 5:07 p.m.
Reviewers: sergei
Base URL: https://hg.adblockplus.org/libadblockplus/
Comments: 17
This is Rietveld