Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/coreUtils.js

Issue 29548719: Issue 5728 - Replace Services.vc.compare (Closed)
Patch Set: Handle case in which the same compnent in both versions are rounded to Infinity Created Sept. 20, 2017, 1:28 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | lib/notification.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 16 matching lines...) Expand all
27 27
28 return descriptor; 28 return descriptor;
29 } 29 }
30 exports.desc = desc; 30 exports.desc = desc;
31 31
32 function extend(cls, properties) 32 function extend(cls, properties)
33 { 33 {
34 return Object.create(cls.prototype, desc(properties)); 34 return Object.create(cls.prototype, desc(properties));
35 } 35 }
36 exports.extend = extend; 36 exports.extend = extend;
37
38 function compareVersion(v1, v2)
39 {
40 let components1 = v1.split(".");
41 let components2 = v2.split(".");
42 let result = 0;
43
44 for (let i = 0; result == 0 && (i < components1.length ||
45 i < components2.length); i++)
46 {
47 let comp1 = components1[i];
48 let comp2 = components2[i];
49
50 result = (comp1 == "*" ? Infinity : parseInt(comp1, 10) || 0) -
51 (comp2 == "*" ? Infinity : parseInt(comp2, 10) || 0) || 0;
52 }
53
54 return result;
55 }
56 exports.compareVersion = compareVersion;
OLDNEW
« no previous file with comments | « no previous file | lib/notification.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld