Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/notification.js

Issue 29548719: Issue 5728 - Replace Services.vc.compare (Closed)
Left Patch Set: Moved compareVersion() into notifications module, handle non-numeric suffix Created Sept. 21, 2017, 9:53 p.m.
Right Patch Set: Addressed comments Created Sept. 23, 2017, 12:07 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « test/_common.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 ["extensionMaxVersion", "1.4.1", true], 177 ["extensionMaxVersion", "1.4.1", true],
178 ["extensionMaxVersion", "1.4.*", true], 178 ["extensionMaxVersion", "1.4.*", true],
179 ["extensionMaxVersion", "1.4", false], 179 ["extensionMaxVersion", "1.4", false],
180 ["application", "chrome", true], 180 ["application", "chrome", true],
181 ["application", "firefox", false], 181 ["application", "firefox", false],
182 ["applicationMinVersion", "27.0", true], 182 ["applicationMinVersion", "27.0", true],
183 ["applicationMinVersion", "27", true], 183 ["applicationMinVersion", "27", true],
184 ["applicationMinVersion", "26", true], 184 ["applicationMinVersion", "26", true],
185 ["applicationMinVersion", "28", false], 185 ["applicationMinVersion", "28", false],
186 ["applicationMinVersion", "27.1", false], 186 ["applicationMinVersion", "27.1", false],
187 ["applicationMinVersion", "27.0b1", true],
187 ["applicationMaxVersion", "27.0", true], 188 ["applicationMaxVersion", "27.0", true],
188 ["applicationMaxVersion", "27", true], 189 ["applicationMaxVersion", "27", true],
189 ["applicationMaxVersion", "28", true], 190 ["applicationMaxVersion", "28", true],
190 ["applicationMaxVersion", "26", false], 191 ["applicationMaxVersion", "26", false],
192 ["applicationMaxVersion", "27.0b1", false],
191 ["platform", "chromium", true], 193 ["platform", "chromium", true],
192 ["platform", "gecko", false], 194 ["platform", "gecko", false],
193 ["platformMinVersion", "12.0", true], 195 ["platformMinVersion", "12.0", true],
194 ["platformMinVersion", "12", true], 196 ["platformMinVersion", "12", true],
195 ["platformMinVersion", "11", true], 197 ["platformMinVersion", "11", true],
196 ["platformMinVersion", "13", false], 198 ["platformMinVersion", "13", false],
197 ["platformMinVersion", "12.1", false], 199 ["platformMinVersion", "12.1", false],
200 ["platformMinVersion", "12.0b1", true],
198 ["platformMaxVersion", "12.0", true], 201 ["platformMaxVersion", "12.0", true],
199 ["platformMaxVersion", "12", true], 202 ["platformMaxVersion", "12", true],
200 ["platformMaxVersion", "13", true], 203 ["platformMaxVersion", "13", true],
201 ["platformMaxVersion", "11", false], 204 ["platformMaxVersion", "11", false],
205 ["platformMaxVersion", "12.0b1", false],
202 ["blockedTotalMin", "11", false], 206 ["blockedTotalMin", "11", false],
203 ["blockedTotalMin", "10", true], 207 ["blockedTotalMin", "10", true],
204 ["blockedTotalMax", "10", true], 208 ["blockedTotalMax", "10", true],
205 ["blockedTotalMax", "1", false], 209 ["blockedTotalMax", "1", false],
206 ["locales", ["en-US"], true], 210 ["locales", ["en-US"], true],
207 ["locales", ["en-US", "de-DE"], true], 211 ["locales", ["en-US", "de-DE"], true],
208 ["locales", ["de-DE"], false], 212 ["locales", ["de-DE"], false],
209 ["locales", ["en-GB", "de-DE"], false] 213 ["locales", ["en-GB", "de-DE"], false]
210 ]) 214 ])
211 { 215 {
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
551 test.done(); 555 test.done();
552 }; 556 };
553 557
554 exports.testMissingTranslation = function(test) 558 exports.testMissingTranslation = function(test)
555 { 559 {
556 let notification = {message: {"en-US": "en-US"}}; 560 let notification = {message: {"en-US": "en-US"}};
557 let texts = Notification.getLocalizedTexts(notification, "fr"); 561 let texts = Notification.getLocalizedTexts(notification, "fr");
558 test.equal(texts.message, "en-US"); 562 test.equal(texts.message, "en-US");
559 test.done(); 563 test.done();
560 }; 564 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld